Re: [PATCH] btrace: diagnose "record btrace pt" without libipt

Pedro Alves
2015-11-26T09:43:01Z

On 11/26/2015 07:12 AM, Metzger, Markus T wrote:
> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Wednesday, November 25, 2015 5:38 PM
> To: Metzger, Markus T <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH] btrace: diagnose "record btrace pt" without libipt
>
>
>> It would be nice if GDB could detect that record btrace is already
>> enabled and push the record-btrace target automatically. I guess this
>> requires some indication about the record status from gdbserver. Is
>> there some other target that does this automatic push on (re-)connect that I could use as reference?
>
> E.g., linux-thread-db.c pushes itself from a new_objfile observer (thread_db_new_objfile), and the spu multiarch target pushes itself from an inferior_created observer (spu_multiarch_inferior_created).
>
> Thanks. I'll look into those examples. It'll take a bit but I don't think this is urgent.

Certainly not urgent.

>
>
> Are you OK to push the patch to avoid the internal error and handle the re-connect
> case in a separate series?

Yes.

>
> That patch might make sense for 7.10.1, as well. OK to push onto the 7.10 branch?

OK. In that case, as per standard procedure, please file a PR and
list it the 7.10 release wiki page.

Thanks,
Pedro Alves