From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115558 invoked by alias); 19 Oct 2015 09:35:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115545 invoked by uid 89); 19 Oct 2015 09:35:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga14.intel.com Received: from mga14.intel.com (HELO mga14.intel.com) (192.55.52.115) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Oct 2015 09:35:28 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 19 Oct 2015 02:35:21 -0700 X-ExtLoop1: 1 Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga002.jf.intel.com with ESMTP; 19 Oct 2015 02:35:20 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 19 Oct 2015 10:35:18 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.150]) by IRSMSX156.ger.corp.intel.com ([169.254.3.245]) with mapi id 14.03.0248.002; Mon, 19 Oct 2015 10:35:18 +0100 From: "Metzger, Markus T" To: Doug Evans CC: "palves@redhat.com" , "dje@google.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH 0/6] disasm, record: fix "record instruction-history /m" Date: Mon, 19 Oct 2015 09:35:00 -0000 Message-ID: References: <1442847283-10200-1-git-send-email-markus.t.metzger@intel.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00328.txt.bz2 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBnZGItcGF0 Y2hlcy1vd25lckBzb3VyY2V3YXJlLm9yZyBbbWFpbHRvOmdkYi1wYXRjaGVz LQ0KPiBvd25lckBzb3VyY2V3YXJlLm9yZ10gT24gQmVoYWxmIE9mIERvdWcg RXZhbnMNCj4gU2VudDogU3VuZGF5LCBPY3RvYmVyIDE4LCAyMDE1IDExOjE3 IFBNDQo+IFRvOiBNZXR6Z2VyLCBNYXJrdXMgVA0KPiBDYzogcGFsdmVzQHJl ZGhhdC5jb207IGRqZUBnb29nbGUuY29tOyBnZGItcGF0Y2hlc0Bzb3VyY2V3 YXJlLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDAvNl0gZGlzYXNtLCBy ZWNvcmQ6IGZpeCAicmVjb3JkIGluc3RydWN0aW9uLWhpc3RvcnkgL20iDQoN CkhpIERvdWcsDQoNCj4gPiBHaXZlbiB0aGUgY29uY2VybnMgYWJvdXQgaW5j cmVhc2VkIG1lbW9yeSBjb25zdW1wdGlvbiBhbmQgcnVuLXRpbWUNCj4gPiBv dmVyaGVhZCBpbiBwYXRjaCAzIGFuZCB0aGUgY2hhbmdlcyB0byB0aGUgc291 cmNlIGludGVybGVhdmluZyBhbGdvcml0aG0NCj4gPiBpbiBwYXRjaGVzIDQg YW5kIDUsIEknZCBnbyB3aXRoIGEgbW9kaWZpZWQgdmVyc2lvbiBvZiBteSBv cmlnaW5hbCBSRkMsIGkuZS4NCj4gPg0KPiA+ICAgLSBwYXRjaGVzIDEgYW5k IDIgZnJvbSB0aGlzIHNlcmllcw0KPiA+ICAgLSB0aGUgcmZjIHBhdGNoIHRv IGludGVybGVhdmUgc291cmNlcyBpbiByZWNvcmQtYnRyYWNlLmMNCj4gPiAg IC0gcGF0Y2ggNiBmcm9tIHRoaXMgc2VyaWVzDQo+ID4NCj4gPiBUaGlzIHdp bGwgbGVhdmUgdXMgd2l0aCB0d28gc291cmNlIGludGVybGVhdmluZyBhbGdv cml0aG1zLCBvbmUgZm9yIGENCj4gPiBjb25zZWN1dGl2ZSByYW5nZSBvZiBt ZW1vcnksIGFuZCBvbmUgZm9yIGEgc2VxdWVuY2Ugb2YgaW5zdHJ1Y3Rpb25z DQo+ID4gaW4gdGhlIG9yZGVyIGluIHdoaWNoIHRoZXkgd2VyZSByZWNvcmRl ZC4NCj4gPg0KPiA+IEJvdGggd2lsbCB1c2UgYSBzbGlnaHRseSBtb2RpZmll ZCBkdW1wX2luc24gdG8gcHJpbnQgaW5zdHJ1Y3Rpb24gdHVwbGVzLg0KPiA+ DQo+ID4gSSdtIGRyb3BwaW5nIHRoZSBpZGVhIG9mIHByZXBhcmluZyBhIHZl Y3RvciBvZiBpbnN0cnVjdGlvbnMgdG8gcHJpbnQgYW5kDQo+ID4gYW5kIG9m IHRyeWluZyB0byBzaG9laG9ybiByZWNvcmQgaW5zdHJ1Y3Rpb24taGlzdG9y eSdzIHNvdXJjZSBpbnRlcmxlYXZpbmcNCj4gPiBpbnRvIGRvX21peGVkX3Nv dXJjZV9hbmRfYXNzZW1ibHkuDQo+ID4NCj4gPiBEb2VzIHRoYXQgc291bmQg T0s/DQo+IA0KPiBJIHRoaW5rIHNvIChkZXZpbCBpcyBpbiB0aGUgZGV0YWls cykuDQo+IFN1cHBvcnRpbmcgYSB2ZWN0b3Igb2YgaW5zdHJ1Y3Rpb25zIHNv dW5kcyBmaW5lIHRvIG1lIHRob3VnaC4NCj4gVGhlcmUgZG9lc24ndCBoYXZl IHRvIGJlIG9uZSBlbnRyeSBwb2ludCB0byB0aGUgZGlzYXNzZW1ibGVyIEFQ SS4NCj4gWzUgd291bGQgYmUgYmFkLCBidXQgMiBpcyBvazogb25lIHRoYXQg dGFrZXMgYSByYW5nZSwgb25lIHRoYXQgdGFrZXMgYSB2ZWN0b3IuXQ0KDQpQ YXRjaGVzIDQgYW5kIDUgb2YgdGhpcyBzZXJpZXMgbW9kaWZ5IHRoZSBhbGdv cml0aG0gdG8gbWFrZSBpdCB3b3JrIGZvciBpbnN0cnVjdGlvbnMNCmluIHJh bmRvbSBvcmRlci4gIEkgaGF2ZSB0byBkcm9wIHRoZSBzb3VyY2UgbGluZSBo YXNoIHRhYmxlLCBmb3IgZXhhbXBsZSwgYW5kDQpwZXJmb3JtIGEgbXVjaCBt b3JlIGV4cGVuc2l2ZSBzZWFyY2guDQoNCkFsc28gaWYgd2UgZG9uJ3Qgd2Fu dCB0byBjcmVhdGUgYSB0ZW1wb3JhcnkgdmVjdG9yIG9mIGluc3RydWN0aW9u cywgSSdkIGhhdmUgdG8NCmV4dHJhY3QgdGhlIGxvY2FsIHZhcmlhYmxlcyBp bnRvIGFuIGl0ZXJhdGlvbiBzdGF0ZSBzdHJ1Y3QgYW5kIHNwbGl0IHRoZSBh bGdvcml0aG0NCmludG8gc21hbGwgcGllY2VzLg0KDQpJdCdzIHBvc3NpYmxl LCBvZiBjb3Vyc2UsIGJ1dCBJJ20gYWZyYWlkIHlvdSB3b24ndCByZWNvZ25p emUgeW91ciBhbGdvcml0aG0sDQphZnRlcndhcmRzLg0KDQpJIHNlbnQgdjIg b2YgdGhlIHNlcmllcyBhcyBvdXRsaW5lZCBhYm92ZS4NCg0KUmVnYXJkcywN Ck1hcmt1cy4NCkludGVsIERldXRzY2hsYW5kIEdtYkgKUmVnaXN0ZXJlZCBB ZGRyZXNzOiBBbSBDYW1wZW9uIDEwLTEyLCA4NTU3OSBOZXViaWJlcmcsIEdl cm1hbnkKVGVsOiArNDkgODkgOTkgODg1My0wLCB3d3cuaW50ZWwuZGUKTWFu YWdpbmcgRGlyZWN0b3JzOiBDaHJpc3RpbiBFaXNlbnNjaG1pZCwgUHJvZi4g RHIuIEhlcm1hbm4gRXVsCkNoYWlycGVyc29uIG9mIHRoZSBTdXBlcnZpc29y eSBCb2FyZDogVGlmZmFueSBEb29uIFNpbHZhClJlZ2lzdGVyZWQgT2ZmaWNl OiBNdW5pY2gKQ29tbWVyY2lhbCBSZWdpc3RlcjogQW10c2dlcmljaHQgTXVl bmNoZW4gSFJCIDE4NjkyOAo= >From gdb-patches-return-126766-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Oct 19 09:37:30 2015 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 118714 invoked by alias); 19 Oct 2015 09:37:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 118702 invoked by uid 89); 19 Oct 2015 09:37:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout20.012.net.il Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Oct 2015 09:37:28 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NWG00700O15I600@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Mon, 19 Oct 2015 12:37:25 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWG007S3O2CF520@a-mtaout20.012.net.il>; Mon, 19 Oct 2015 12:37:25 +0300 (IDT) Date: Mon, 19 Oct 2015 09:37:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v2 4/4] btrace: add instruction-history /s and fix documentation In-reply-to: <1445246610-11645-5-git-send-email-markus.t.metzger@intel.com> To: Markus Metzger Cc: dje@google.com, gdb-patches@sourceware.org, palves@redhat.com Reply-to: Eli Zaretskii Message-id: <83h9lngpwo.fsf@gnu.org> References: <1445246610-11645-1-git-send-email-markus.t.metzger@intel.com> <1445246610-11645-5-git-send-email-markus.t.metzger@intel.com> X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00330.txt.bz2 Content-length: 812 > From: Markus Metzger > Cc: gdb-patches@sourceware.org, palves@redhat.com > Date: Mon, 19 Oct 2015 11:23:30 +0200 > > +It can also print mixed source+disassembly by specifying the @code{/m} > +or @code{/s} modifier and print the raw instructions in hex as well as > +in symbolic form by specifying the @code{/r} modifier. "By specifying" makes it sound like you are talking about the command, because of the "It" that starts the sentence. Suggest to reword: It can also print mixed source+disassembly if you specify the @code{/m} or @code{/s} modifier, and print the raw instructions in hex as well as in symbolic form by specifying the @code{/r} modifier. Note that I also added a missing comma before "and". The documentation parts are okay with this fixed. Thanks.