From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68106 invoked by alias); 12 Oct 2015 08:44:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68096 invoked by uid 89); 12 Oct 2015 08:44:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Oct 2015 08:44:22 +0000 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 12 Oct 2015 01:44:20 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga003.jf.intel.com with ESMTP; 12 Oct 2015 01:44:19 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.150]) by IRSMSX103.ger.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0248.002; Mon, 12 Oct 2015 09:44:18 +0100 From: "Metzger, Markus T" To: Pedro Alves , "dje@google.com" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 2/6] disasm: add struct disas_insn to describe to-be-disassembled instruction Date: Mon, 12 Oct 2015 08:44:00 -0000 Message-ID: References: <1442847283-10200-1-git-send-email-markus.t.metzger@intel.com> <1442847283-10200-3-git-send-email-markus.t.metzger@intel.com> <5617B840.7040504@redhat.com> In-Reply-To: <5617B840.7040504@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00141.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Friday, October 9, 2015 2:51 PM > To: Metzger, Markus T; dje@google.com > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH 2/6] disasm: add struct disas_insn to describe to-be- > disassembled instruction > I think the log would be much clearer if the rationale was specified in > terms of why this is necessary, and if we saw a before/after example. I added the following to the beginning of the commit message to motivate the patch: The "record instruction-history" command prints for each instruction, in addition to the instruction's disassembly: - the instruction number in the recorded execution trace - a '?' before the instruction if it was executed speculatively To allow the "record instruction-history" command to use GDB's disassembly infrastructure, we extend dump_insn to optionally print those additional fields. > Also, being a user/frontend visible change, shouldn't these new > fields be documented and mentioned in NEWS? There is no UI change and thus also no before/after example. The new optional fields are currently not used. They will be used by the "record instruction-history" command in the last patch of this series. Even then, there is no UI change. Both the "record instruction-history" and the "disassemble" command behave as they did before. There is a change to the MI output of "record instruction-history". As I didn't do any conscious MI support for record btrace, I don't expect it to be working. I'm using the ui_out_* functions so there might be some form of MI support. AFAIK it is not being used. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul Chairperson of the Supervisory Board: Tiffany Doon Silva Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928