From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36908 invoked by alias); 22 Sep 2015 06:18:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36889 invoked by uid 89); 22 Sep 2015 06:18:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Sep 2015 06:18:16 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 21 Sep 2015 23:18:14 -0700 X-ExtLoop1: 1 Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga001.fm.intel.com with ESMTP; 21 Sep 2015 23:18:13 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 22 Sep 2015 07:18:11 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.46]) by irsmsx112.ger.corp.intel.com ([169.254.1.176]) with mapi id 14.03.0248.002; Tue, 22 Sep 2015 07:18:11 +0100 From: "Metzger, Markus T" To: Andrew Burgess CC: "palves@redhat.com" , "dje@google.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH 6/6] btrace: use gdb_disassembly_vec and new source interleaving method Date: Tue, 22 Sep 2015 06:18:00 -0000 Message-ID: References: <1442847283-10200-1-git-send-email-markus.t.metzger@intel.com> <1442847283-10200-7-git-send-email-markus.t.metzger@intel.com> <20150921214813.GA5430@embecosm.com> In-Reply-To: <20150921214813.GA5430@embecosm.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00521.txt.bz2 > -----Original Message----- > From: Andrew Burgess [mailto:andrew.burgess@embecosm.com] > Sent: Monday, September 21, 2015 11:48 PM > To: Metzger, Markus T > Cc: palves@redhat.com; dje@google.com; gdb-patches@sourceware.org > Subject: Re: [PATCH 6/6] btrace: use gdb_disassembly_vec and new source > interleaving method Hello Andrew, Thanks for your feedback. > > Use the new source interleaving method. We stick to the /m modifier. > > The old version is broken and there's no point in keeping it as alterna= tive > > to this new version. > > > > /* The to_insn_history method of target record-btrace. */ > > diff --git a/gdb/record.c b/gdb/record.c > > index 71ef973..c17b199 100644 > > --- a/gdb/record.c > > +++ b/gdb/record.c > > @@ -458,7 +458,7 @@ get_insn_history_modifiers (char **arg) > > switch (*args) > > { > > case 'm': > > - modifiers |=3D DISASSEMBLY_SOURCE_DEPRECATED; > > + modifiers |=3D DISASSEMBLY_SOURCE; > > modifiers |=3D DISASSEMBLY_FILENAME; > > break; > > case 'r': >=20 > I think that we should make /s the official modifier in order to match > the disassembler modifier. >=20 > We should definitely keep /m for backwards compatibility, though I > don't have an issue with it's behaviour changing to match /s. My > concern is more about trying to keep the flags consistent as much as > possible. The change in flags would need a NEWS and manual update. Adding '/s' is fine with me. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul Chairperson of the Supervisory Board: Tiffany Doon Silva Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928