From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54466 invoked by alias); 21 Sep 2015 06:31:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54453 invoked by uid 89); 21 Sep 2015 06:31:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Sep 2015 06:31:24 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 20 Sep 2015 23:31:23 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by FMSMGA003.fm.intel.com with ESMTP; 20 Sep 2015 23:31:23 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.46]) by IRSMSX101.ger.corp.intel.com ([169.254.1.139]) with mapi id 14.03.0248.002; Mon, 21 Sep 2015 07:31:21 +0100 From: "Metzger, Markus T" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] btrace, testsuite: fix spurious gdb.btrace/tsx.exp fails Date: Mon, 21 Sep 2015 06:31:00 -0000 Message-ID: References: <1442565363-13628-1-git-send-email-markus.t.metzger@intel.com> <55FBF91C.8070703@redhat.com> <55FC0A07.1090208@redhat.com> In-Reply-To: <55FC0A07.1090208@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00498.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Friday, September 18, 2015 2:57 PM > To: Metzger, Markus T > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH] btrace, testsuite: fix spurious gdb.btrace/tsx.exp f= ails > > A transaction can be aborted for various reasons. One such reason is an > > interrupt, which can happen at any time. >=20 > I was under the impression that the hardware or kernel would retry > the transaction and that that would be transparent to > userspace, but sounds like not then. For RTM you have to provide the abort handler, yourself. You may retry the transaction or fall back to more heavy-weight synchronization. > > This occurs very infrequently. After I saw this the first time, I had = to re-run > > the test several dozen times to reproduce it again. >=20 > +gdb_test_multiple "record instruction-history" "speculation indication" { > + -re "$abort_1.*$gdb_prompt $" { > + pass "speculation indication: abort" > + } > + -re "$abort_2.*$gdb_prompt $" { > + pass "speculation indication: abort" > + } > + -re "$begin_to_end.*$gdb_prompt $" { > + pass "speculation indication: begin..end" > + } > +} >=20 > Note this will cause ping-ponging of PASS messages, resulting > in spurious changes in test result diffing. I'd suggest using > the same message in all cases. OK. I'll send an updated patch. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul Chairperson of the Supervisory Board: Tiffany Doon Silva Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928