From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28870 invoked by alias); 15 Sep 2015 09:29:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28858 invoked by uid 89); 15 Sep 2015 09:29:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Sep 2015 09:29:31 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 15 Sep 2015 02:29:29 -0700 X-ExtLoop1: 1 Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga002.fm.intel.com with ESMTP; 15 Sep 2015 02:28:38 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.201]) by IRSMSX106.ger.corp.intel.com ([169.254.8.112]) with mapi id 14.03.0224.002; Tue, 15 Sep 2015 10:28:37 +0100 From: "Metzger, Markus T" To: Jan Kratochvil , Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 17/17] infrun: scheduler-locking reverse Date: Tue, 15 Sep 2015 09:29:00 -0000 Message-ID: References: <1441794909-32718-1-git-send-email-markus.t.metzger@intel.com> <1441794909-32718-18-git-send-email-markus.t.metzger@intel.com> <55F03A12.80307@redhat.com> <20150912194344.GA7575@host1.jankratochvil.net> In-Reply-To: <20150912194344.GA7575@host1.jankratochvil.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00307.txt.bz2 > -----Original Message----- > From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com] > Sent: Saturday, September 12, 2015 9:44 PM > To: Pedro Alves > Cc: Metzger, Markus T; gdb-patches@sourceware.org > Subject: Re: [PATCH 17/17] infrun: scheduler-locking reverse Hello Jan, > Thanks for bringing it up. I would have hard time mergin this patch's: > -static const char *scheduler_mode =3D schedlock_off; > +static const char *scheduler_mode =3D schedlock_reverse; > with > http://pkgs.fedoraproject.org/cgit/gdb.git/tree/gdb-6.6-scheduler_locking- > step-is-default.patch > -static const char *scheduler_mode =3D schedlock_off; > +static const char *scheduler_mode =3D schedlock_step; I don't believe that we need to preserve the current behaviour. If Fedora defaults to schedlock_step, why not also for record targets? It could be seen as bug-fix that record targets did not honour scheduler-lo= cking. The same holds for mainline, of course. But the new mode is much closer to schedlock_step than it is to schedlock_off. > My guess is there could be a new setting "set reverse-scheduler-locking" = also > with "off/step/on" as it seems to me "step" also makes sense for the > scheduler > locking in reverse mode. This would allow us to set different scheduler-locking modes for reverse/re= play execution and for normal debugging. While this adds flexibility, I'm not s= ure it is actually needed. I really only added the new mode because I did not want to change the defau= lt behaviour completely. Over time, I think we may want to deprecate it, even though schedlock_off isn't very useful with the usually quite short executi= on history. Maybe mainline will default to schedlock_step one day, as well? Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul Chairperson of the Supervisory Board: Tiffany Doon Silva Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928