From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1703 invoked by alias); 9 Sep 2015 12:20:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1692 invoked by uid 89); 9 Sep 2015 12:20:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Sep 2015 12:20:53 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 09 Sep 2015 05:20:51 -0700 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 09 Sep 2015 05:20:50 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.201]) by IRSMSX102.ger.corp.intel.com ([169.254.2.81]) with mapi id 14.03.0224.002; Wed, 9 Sep 2015 13:20:49 +0100 From: "Metzger, Markus T" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 13/17] btrace: non-stop Date: Wed, 09 Sep 2015 12:20:00 -0000 Message-ID: References: <1441794909-32718-1-git-send-email-markus.t.metzger@intel.com> <1441794909-32718-14-git-send-email-markus.t.metzger@intel.com> <55F01DEC.4030209@redhat.com> In-Reply-To: <55F01DEC.4030209@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00127.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Wednesday, September 9, 2015 1:54 PM > To: Metzger, Markus T > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH 13/17] btrace: non-stop >=20 > On 09/09/2015 11:35 AM, Markus Metzger wrote: >=20 > > +# make sure $line matches the full expected output per thread. > > +# and let's hope that GDB never mixes the output from different thread= s. > > +# > > +# this is quite fragile, mostly because the prompt appears somewhere in > > +# the middle of the output. > > +proc gdb_cont_to { threads cmd line nthreads } { > > + global gdb_prompt > > + set full_cmd "thread apply $threads $cmd" > > + set prompt_seen 0 > > + > > + send_gdb "$full_cmd\n" > > + > > + for {set i 0} {$i < $nthreads} {incr i} { > > + set test "$full_cmd: thread $i" > > + > > + # check for the prompt. it may be in front of one of the line= s we > > + # try to match. > > + gdb_test_multiple "" "$test: check prompt" { > > + -notransfer -re "$gdb_prompt " { > > + set prompt_seen 1 > > + } > > + } > > + >=20 > Hmmm. I'm not sure I'm missing some subtlety, but it seems to me > that if you used -notransfer, then the prompt will still be in the buffer, > and ... >=20 > > + # check for the line. and for a typical error. > > + gdb_test_multiple "" $test { > > + -re "Cannot execute this command \[^\\\r\\\n\]* is running= \." { > > + fail $test > > + } > > + -re "$line\[^\\\r\\\n\]*\r\n" { > > + pass $test > > + } > > + } >=20 > ... thus this gdb_test_multiple can trip on it and issue a fail. As far as I understand expect, the above gdb_test_multiple would simply skip the $gdb_prompt at the beginning of the line. That's why I'm trying to detect it with a separate gdb_test_multiple above. I use -notransfer so I can still analyse the line for the expected output. > Wouldn't this instead work? >=20 > gdb_test_multiple "" $test { > -re "Cannot execute this command \[^\\\r\\\n\]* is running\."= { > fail $test > } > -re "$line\[^\\\r\\\n\]*\r\n" { > pass $test > } > -re "$gdb_prompt " { > set prompt_seen 1 > exp_continue > } > } Wouldn't the 1st or 2nd pattern skip any $gdb_prompt before the pattern? For the "Cannot execute..." pattern, I could add "^" but this will be diffi= cult for the $line pattern. Does the 3rd pattern consume just the $gdb_prompt or the entire line? This non-stop testing is quite difficult. I also have not found too many examples when I searched for "non-stop". thanks, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul Chairperson of the Supervisory Board: Tiffany Doon Silva Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928