RE: [PATCH 1/4] btrace: fix build fail with 32-bit BFD

Metzger, Markus T
2015-07-13T07:39:02Z

> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Wednesday, July 8, 2015 3:42 PM
> To: Metzger, Markus T
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH 1/4] btrace: fix build fail with 32-bit BFD
>
> On 07/08/2015 01:54 PM, Markus Metzger wrote:
> > When compiling GDB with 32-bit BFD, the build fails with:
> >
> > In file included from btrace.h:33:0,
> > from btrace.c:23:
> > /usr/include/intel-pt.h:1643:51: note: expected 'int (*)(uint8_t *, size_t,
> > const struct pt_asid *, uint64_t, void *)' but argument is of type 'int
> > (*)(gdb_byte *, size_t, const struct pt_asid *, CORE_ADDR, void *)' extern
> > pt_export int pt_image_set_callback(struct pt_image *image, ^
> >
> > Fix it.
> >
> > 2015-07-08 Markus Metzger <markus.t.metzger@intel.com>
> >
> > gdb/
> > * btrace.c (btrace_pt_readmem_callback): Change type of PC
> argument.
>
> OK.

Would this make sense for GDB 7.10, as well?

Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul
Chairperson of the Supervisory Board: Tiffany Doon Silva
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928