From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93447 invoked by alias); 10 Jul 2015 07:17:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93438 invoked by uid 89); 10 Jul 2015 07:17:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jul 2015 07:17:09 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 10 Jul 2015 00:16:39 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 10 Jul 2015 00:16:38 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 10 Jul 2015 08:16:37 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.171]) by IRSMSX156.ger.corp.intel.com ([169.254.3.125]) with mapi id 14.03.0224.002; Fri, 10 Jul 2015 08:16:37 +0100 From: "Metzger, Markus T" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 2/2] ari, btrace: avoid unsigned long long Date: Fri, 10 Jul 2015 07:17:00 -0000 Message-ID: References: <1436422132-8936-1-git-send-email-markus.t.metzger@intel.com> <1436422132-8936-2-git-send-email-markus.t.metzger@intel.com> <559E57C0.90006@redhat.com> In-Reply-To: <559E57C0.90006@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00312.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Thursday, July 9, 2015 1:15 PM > To: Metzger, Markus T > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH v2 2/2] ari, btrace: avoid unsigned long long >=20 > On 07/09/2015 07:08 AM, Markus Metzger wrote: > > Fix the ARI warning about the use of unsigned long long. We can't use > ULONGEST > > as this is defined unsigned long on 64-bit systems. >=20 > But, what exactly would break? I changed the commit message to this: Fix the ARI warning about the use of unsigned long long. We can't use ULONGEST as this is defined unsigned long on 64-bit systems. This will result in a compile error when storing a pointer to an unsigned long lo= ng structure field (declared in perf_evene.h as __u64) in a ULONGEST * var= iable. =20=20=20=20 Use unsigned long to hold the buffer size inside GDB and __u64 when interfacing the kernel. Is that OK? > > Use unsigned long to hold > > the buffer size inside GDB >=20 > Why not use size_t instead then? It's another typedef. And without a clearly defined size. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul Chairperson of the Supervisory Board: Tiffany Doon Silva Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928