From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21543 invoked by alias); 8 Jul 2015 15:08:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21515 invoked by uid 89); 8 Jul 2015 15:08:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Jul 2015 15:08:43 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 08 Jul 2015 08:07:27 -0700 X-ExtLoop1: 1 Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga002.jf.intel.com with ESMTP; 08 Jul 2015 08:07:28 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.171]) by IRSMSX108.ger.corp.intel.com ([169.254.11.201]) with mapi id 14.03.0224.002; Wed, 8 Jul 2015 16:07:15 +0100 From: "Metzger, Markus T" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 2/4] record: set stop_pc in "record goto" command Date: Wed, 08 Jul 2015 15:08:00 -0000 Message-ID: References: <1436360074-8625-1-git-send-email-markus.t.metzger@intel.com> <1436360074-8625-2-git-send-email-markus.t.metzger@intel.com> <559D28A4.3040402@redhat.com> In-Reply-To: <559D28A4.3040402@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00223.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Wednesday, July 8, 2015 3:42 PM > To: Metzger, Markus T > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH 2/4] record: set stop_pc in "record goto" command >=20 > On 07/08/2015 01:54 PM, Markus Metzger wrote: >=20 > > 2015-07-08 Markus Metzger > > > > gdb/ > > * record-btrace.c (record_btrace_goto_begin, > record_btrace_goto_end) > > record_btrace_goto): Set stop_pc. Call reinit_frame_cache. > > * record-full.c (record_full_goto_entry): Set stop_pc. > > > > testsuite/ > > * gdb.btrace/record_goto-step.exp: New. > > --- > > gdb/record-btrace.c | 6 ++++ > > gdb/record-full.c | 1 + > > gdb/testsuite/gdb.btrace/record_goto-step.exp | 46 > +++++++++++++++++++++++++++ > > 3 files changed, 53 insertions(+) > > create mode 100644 gdb/testsuite/gdb.btrace/record_goto-step.exp > > > > diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c > > index 969e01b..3870400 100644 > > --- a/gdb/record-btrace.c > > +++ b/gdb/record-btrace.c > > @@ -2227,6 +2227,8 @@ record_btrace_goto_begin (struct target_ops > *self) > > btrace_insn_begin (&begin, &tp->btrace); > > record_btrace_set_replay (tp, &begin); > > > > + reinit_frame_cache (); > > + stop_pc =3D regcache_read_pc (get_current_regcache ()); >=20 > I think you should do this within record_btrace_set_replay, > instead of doing the same in several places. OK. I also moved the call to print_stack_frame. > Also, I don't think you need the reinit_frame_cache call, as the > registers_changed_ptid calls in > record_btrace_set_replay/record_btrace_stop_replaying take care of > it already. OK. I'll reorder the patches, commit the approved ones, and send updated versio= ns of the two you had comments on. Is that OK with you? Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul Chairperson of the Supervisory Board: Tiffany Doon Silva Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928