From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30811 invoked by alias); 14 Nov 2014 13:47:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30795 invoked by uid 89); 14 Nov 2014 13:47:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Nov 2014 13:47:42 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 14 Nov 2014 05:45:10 -0800 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 14 Nov 2014 05:47:39 -0800 Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 14 Nov 2014 13:47:38 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.116]) by IRSMSX106.ger.corp.intel.com ([169.254.8.101]) with mapi id 14.03.0195.001; Fri, 14 Nov 2014 13:47:38 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 02/12] btrace: add format argument to supports_btrace Date: Fri, 14 Nov 2014 13:47:00 -0000 Message-ID: References: <1405346196-1804-1-git-send-email-markus.t.metzger@intel.com> <1405346196-1804-3-git-send-email-markus.t.metzger@intel.com> <545A8C5B.3040504@redhat.com> <5466056E.5060202@redhat.com> In-Reply-To: <5466056E.5060202@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00305.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Friday, November 14, 2014 2:37 PM > >>> +enum btrace_read_type > >>> +{ > >>> + /* Send all available trace. */ > >>> + BTRACE_READ_ALL, > >>> + > >>> + /* Send all available trace, if it changed. */ > >>> + BTRACE_READ_NEW, > >>> + > >>> + /* Send the trace since the last request. This will fail if the t= race > >>> + buffer overflowed. */ > >>> + BTRACE_READ_DELTA > >>> +}; > >> > >> What does "Send" mean here? > > > > It means as much as "read". It determines what trace you'll get > > when reading btrace. > > I realize it's the producer's view; it should rather be the consumer's > > view. >=20 > Ah, yeah. >=20 > > Do you want me to change it in a separate patch? >=20 > Hmm, I'm confused -- why a separate patch instead of simply > adjusting this one? Because this chunk will go away. As you pointed out, moving declarations around is no longer necessary and this change is unrelated. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052