From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31523 invoked by alias); 2 Jun 2014 09:43:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31506 invoked by uid 89); 2 Jun 2014 09:43:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Jun 2014 09:43:08 +0000 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 02 Jun 2014 02:43:02 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by azsmga001.ch.intel.com with ESMTP; 02 Jun 2014 02:43:00 -0700 Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 2 Jun 2014 10:43:00 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.136]) by IRSMSX106.ger.corp.intel.com ([169.254.8.14]) with mapi id 14.03.0123.003; Mon, 2 Jun 2014 10:42:59 +0100 From: "Metzger, Markus T" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v3 3/3] btrace, vdso: add vdso target sections Date: Mon, 02 Jun 2014 09:43:00 -0000 Message-ID: References: <1400655682-4014-1-git-send-email-markus.t.metzger@intel.com> <1400655682-4014-3-git-send-email-markus.t.metzger@intel.com> <5387663A.5040704@redhat.com> <53876874.3080503@redhat.com> In-Reply-To: Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00016.txt.bz2 > -----Original Message----- > From: Metzger, Markus T > Sent: Monday, June 2, 2014 10:21 AM > To: Pedro Alves > Cc: gdb-patches@sourceware.org > Subject: RE: [PATCH v3 3/3] btrace, vdso: add vdso target sections >=20 > Thanks for reporting this crash. I'll look into it. I thought I ran all= tests > for each patch in the vdso series. >=20 > It seems btrace got broken, as well. I now get an assertion: " > to_execution_direction must be implemented ...". The trivial solution > of providing a to_execution_direction method that just returns > execution_direction does not seem to work - or there's another > bug underneath. Looks like btrace got broken when async was made default and btrace did not support it. I took the async bits from record-full and now at least the btrace tests are running again. I'll send the patch in a separate email. Regards, Markus. >=20 > Regards, > Markus. >=20 > > -----Original Message----- > > From: Pedro Alves [mailto:palves@redhat.com] > > Sent: Thursday, May 29, 2014 7:04 PM > > To: Metzger, Markus T > > Cc: gdb-patches@sourceware.org > > Subject: Re: [PATCH v3 3/3] btrace, vdso: add vdso target sections > > > > On 05/29/2014 05:54 PM, Pedro Alves wrote: > > > Hi Markus, > > > > > > On 05/21/2014 08:01 AM, Markus Metzger wrote: > > >> When loading symbols for the vdso, also add its sections to > > target_sections. > > >> > > >> This fixes an issue with record btrace where vdso instructions could= not > be > > >> disassembled during replay. > > >> > > >> 2014-05-21 Markus Metzger > > >> > > >> * symfile-mem.c (symbol_file_add_from_memory): Add BFD > > sections. > > > > > > Unfortunately this caused regressions in break-interp.exp: > > > > > > Running ../../../src/gdb/testsuite/gdb.base/break-interp.exp ... > > > ERROR: Process no longer exists > > > > > > That is GDB crashing. > > > > > > 589fdceb99db9868e34bc976b7e234dbfaf327e2 is the first bad commit > > > commit 589fdceb99db9868e34bc976b7e234dbfaf327e2 > > > Author: Markus Metzger > > > Date: Wed Apr 2 09:54:11 2014 +0200 > > > > > > btrace, vdso: add vdso target sections > > > > > > When loading symbols for the vdso, also add its sections to > > target_sections. > > > > > > This fixes an issue with record btrace where vdso instructions co= uld not > > be > > > disassembled during replay. > > > > > > * symfile-mem.c (symbol_file_add_from_memory): Add BFD > sections. > > > > > > testsuite/ > > > * gdb.btrace/vdso.c: New. > > > * gdb.btrace/vdso.exp: New. > > > > > > > > > Core was generated by > > `/home/pedro/gdb/mygit/build/gdb/testsuite/../../gdb/gdb -nw -nx -data- > > directory'. > > > Program terminated with signal SIGSEGV, Segmentation fault. > > > #0 0x0000000000647bce in exec_set_section_address > > (filename=3D0x27bb1f0 > > "/home/pedro/gdb/mygit/build/gdb/testsuite/gdb.base/break-interp- > > LDprelinkNOdebugNO", index=3D0, > > > address=3D139930618982856) at ../../src/gdb/exec.c:919 > > > 919 if (filename_cmp (filename, p->the_bfd_section->owner- > > >filename) =3D=3D 0 > > > > 'p', a target section, points at garbage. > > > > Hmm, wait, nothing is removing the vdso symbols target sections, like e= ver, > > not even when the process dies, isn't it? I guess that's it. > > > > -- > > Pedro Alves Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052