From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22457 invoked by alias); 19 May 2014 07:51:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22445 invoked by uid 89); 19 May 2014 07:51:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 May 2014 07:51:17 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 19 May 2014 00:46:10 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 19 May 2014 00:51:14 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.98]) by IRSMSX103.ger.corp.intel.com ([163.33.3.157]) with mapi id 14.03.0123.003; Mon, 19 May 2014 08:51:12 +0100 From: "Metzger, Markus T" To: Pedro Alves , Eli Zaretskii CC: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" Subject: RE: [rfc] btrace: control memory access during replay Date: Mon, 19 May 2014 07:51:00 -0000 Message-ID: References: <1396601781-25010-1-git-send-email-markus.t.metzger@intel.com> <8361mpa1z9.fsf@gnu.org> <8338hta0hm.fsf@gnu.org> <53738D3E.60606@redhat.com> In-Reply-To: <53738D3E.60606@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00330.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Wednesday, May 14, 2014 5:35 PM > On 04/04/2014 10:48 AM, Eli Zaretskii wrote: > >>> Other than that, the documentation parts are approved. However, I > >>> wonder whether "allow-memory-access" is a good name for a setting > >>> which actually allows access to writable portion of the memory. IOW, > >>> even when the value is OFF, we do allow access to memory, just not the > >>> writable portion of it. > >> > >> Agreed; allow-access-to-writable-memory-while-replaying is a bit long, > though. > > > > How about access-writable-memory? >=20 > Sounds fine to me. >=20 > What's the likelihood of another variant appearing? That is, > I'm mildly wondering if it should be an enum from the get go: >=20 > set record btrace replay-memory-access read-only|read-write|...|... I don't see another variant right now but I also don't see why it shouldn't be an enum. > I also got a little confused with: >=20 > "The accessed memory corresponds to the end of the recorded > execution trace." >=20 > Maybe we should say "live program" instead ? Would "live program" still be OK for core files? > Also, I think it'd be good to add an into to the manual explaining > the use case. Something like: >=20 > The btrace record target does not trace data. As a convenience, > when replaying, GDB reads read-only memory off the live program > directly, assuming that the addresses of the read-only areas > don't change. This for example makes it possible to disassemble > code while replaying, but not to print variables. > In some cases, being able to inspect variables might be useful. > You can use the following command for that: Will do. > I actually didn't see anything in the patch that actually makes the > setting work. The patch is using an existing variable to guard writable memory access. We already allow write-access for breakpoints during replay. This patch is now adding a CLI for the guard variable. > Also, please install a show hook in the command, so that i18n > can work. I'm using the default set/show functions with _("") descriptions for both set and show. Isn't that enough for i18n? In case it isn't, would I need a set function, as well? Thanks, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052