From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13023 invoked by alias); 17 Jan 2014 08:28:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13013 invoked by uid 89); 17 Jan 2014 08:28:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2014 08:28:37 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 17 Jan 2014 00:28:35 -0800 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga002.fm.intel.com with ESMTP; 17 Jan 2014 00:28:34 -0800 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 17 Jan 2014 08:28:33 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.135]) by IRSMSX153.ger.corp.intel.com ([169.254.9.156]) with mapi id 14.03.0123.003; Fri, 17 Jan 2014 08:28:33 +0000 From: "Metzger, Markus T" To: Tom Tromey CC: "jan.kratochvil@redhat.com" , "palves@redhat.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v10 25/28] btrace, gdbserver: read branch trace incrementally Date: Fri, 17 Jan 2014 08:28:00 -0000 Message-ID: References: <1389686678-9039-1-git-send-email-markus.t.metzger@intel.com> <1389686678-9039-26-git-send-email-markus.t.metzger@intel.com> <87r487n724.fsf@fleche.redhat.com> In-Reply-To: <87r487n724.fsf@fleche.redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00669.txt.bz2 > -----Original Message----- > From: Tom Tromey [mailto:tromey@redhat.com] > Sent: Thursday, January 16, 2014 6:57 PM > Markus> -VEC (btrace_block_s) * > Markus> -target_read_btrace (struct btrace_target_info *btinfo, > Markus> +enum btrace_error > Markus> +target_read_btrace (VEC (btrace_block_s) **btrace, > Markus> + struct btrace_target_info *btinfo, > Markus> enum btrace_read_type type) > Markus> { > Markus> struct target_ops *t; >=20 > Markus> for (t =3D current_target.beneath; t !=3D NULL; t =3D t->benea= th) > Markus> if (t->to_read_btrace !=3D NULL) > Markus> - return t->to_read_btrace (btinfo, type); > Markus> + return t->to_read_btrace (btrace, btinfo, type); >=20 > Markus> tcomplain (); > Markus> - return NULL; > Markus> + return BTRACE_ERR_NOT_SUPPORTED; > Markus> } >=20 > While rebasing my branch I noticed this code. >=20 > tcomplain doesn't return, so the final "return" here will never be > executed. >=20 > Given the function's history I assume this is no big deal -- just a > small oversight, compounded by the compiler not bothering to tell us > that it knows about this :) >=20 > However I wanted to point it out in case you were expecting an error > return here. I am expecting the exception from tcomplain (). The return BTRACE_ERR_NOT_SUPPORTED is to avoid warnings from compilers that can't figure out that tcomplain () does not return. I used to return NULL before and I'm using the same pattern in target_enable_btrace. There's another instance in dummy_get_bookmark. If this turns out to be unnecessary, I can send a patch to remove those extra returns. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052