From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20862 invoked by alias); 20 Dec 2013 14:37:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20852 invoked by uid 89); 20 Dec 2013 14:37:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2013 14:37:17 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 20 Dec 2013 06:37:15 -0800 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 20 Dec 2013 06:37:14 -0800 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 20 Dec 2013 14:36:50 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.135]) by IRSMSX153.ger.corp.intel.com ([169.254.9.156]) with mapi id 14.03.0123.003; Fri, 20 Dec 2013 14:36:39 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" , Eli Zaretskii Subject: RE: [PATCH v9 29/29] record-btrace: add (reverse-)stepping support Date: Fri, 20 Dec 2013 14:37:00 -0000 Message-ID: References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-30-git-send-email-markus.t.metzger@intel.com> <52B3529E.70407@redhat.com> In-Reply-To: <52B3529E.70407@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00835.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Thursday, December 19, 2013 9:10 PM > > + if (non_stop) > > + error (_("Record btrace can't debug inferior in non-stop mode " > > + "(non-stop).")); >=20 > What's the intent of saying non-stop twice, in: >=20 > "in non-stop mode (non-stop)" I took this from s/w record without thinking. Fixed. > > + /* Stop all other threads. */ > > + if (!non_stop) > > + ALL_THREADS (other) > > + other->btrace.flags &=3D ~BTHR_MOVE; >=20 > (I know it doesn't work currently), but in non-stop, the > event thread should also get its BTHR_MOVE flag cleared. > I didn't spot where that was being done. It's done in record_btrace_step_thread right at the beginning. > > + /* GDB seems to need this. Without, a stale PC seems to be used > resulting in > > + the current location to be displayed incorrectly. */ > > + registers_changed_ptid (tp->ptid); >=20 > This really shouldn't be necessary, given target_resume does > it for you. If you still needed, you're papering over some > problem. If we start replaying in to_wait, we'll call get_current_frame to fix up some stepping related frames. This will be done on the current PC. When we step later on in record_btrace_step_thread, we change the replay position but not the PC. I guess it will be more clear when I move this into record_btrace_step_thread and change the comment. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052