From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1286 invoked by alias); 17 Dec 2013 12:56:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1274 invoked by uid 89); 17 Dec 2013 12:56:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Dec 2013 12:56:47 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 17 Dec 2013 04:52:51 -0800 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga001.jf.intel.com with ESMTP; 17 Dec 2013 04:56:28 -0800 Received: from irsmsx105.ger.corp.intel.com (163.33.3.28) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 17 Dec 2013 12:56:27 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.135]) by IRSMSX105.ger.corp.intel.com ([169.254.7.215]) with mapi id 14.03.0123.003; Tue, 17 Dec 2013 12:56:27 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" Subject: RE: [patch v8 21/24] record-btrace: extend unwinder Date: Tue, 17 Dec 2013 12:56:00 -0000 Message-ID: References: <1386839747-8860-1-git-send-email-markus.t.metzger@intel.com> <1386839747-8860-22-git-send-email-markus.t.metzger@intel.com> <52AB63BB.30206@redhat.com> <52AF5302.4010308@redhat.com> In-Reply-To: <52AF5302.4010308@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00641.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Monday, December 16, 2013 8:23 PM > >>> @@ -222,7 +222,11 @@ enum frame_type > >>> ARCH_FRAME, > >>> /* Sentinel or registers frame. This frame obtains register values > >>> direct from the inferior's registers. */ > >>> - SENTINEL_FRAME > >>> + SENTINEL_FRAME, > >>> + /* A branch tracing frame. */ > >>> + BTRACE_FRAME, > >>> + /* A branch tracing tail call frame. */ > >>> + BTRACE_TAILCALL_FRAME > >>> }; > >> > >> Hmm? Why were these needed? Missing patch rationale... And missing > >> comments, I suppose. > > > > The alternative would be to pretend that they are NORMAL_FRAME > > and TAILCALL_FRAME, respectively. I thought it cleaner to add a new > > frame type. Those frames don't have available stack. > > > > Do you want me to use NORMAL_FRAME and TAILCALL_FRAME, instead? >=20 > If they behave example like those, then yes. I wouldn't call > it "pretend" then. This is IMO just like we don't have other > frames types for the many different implementations of > NORMAL_FRAMEs or SIGTRAP_FRAME unwinders, etc., and likewise for > when inspecting tracepoint traceframes with unavailable stack. > IOW, is there any place in the common code that needs to > distinguish NORMAL_FRAME vs BTRACE_FRAME and TAILCALL_FRAME > vs BTRACE_TAILCALL_FRAME? They behave the same. I'll remove the new frame types. Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052