From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25965 invoked by alias); 17 Dec 2013 08:26:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25949 invoked by uid 89); 17 Dec 2013 08:26:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Dec 2013 08:26:47 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 17 Dec 2013 00:22:56 -0800 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 17 Dec 2013 00:26:27 -0800 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 17 Dec 2013 08:26:26 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.135]) by IRSMSX153.ger.corp.intel.com ([169.254.9.129]) with mapi id 14.03.0123.003; Tue, 17 Dec 2013 08:26:01 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" Subject: RE: [patch v8 15/24] frame, backtrace: allow targets to supply a frame unwinder Date: Tue, 17 Dec 2013 08:26:00 -0000 Message-ID: References: <1386839747-8860-1-git-send-email-markus.t.metzger@intel.com> <1386839747-8860-16-git-send-email-markus.t.metzger@intel.com> <52AB5194.2050205@redhat.com> <52AF4E2C.2060408@redhat.com> In-Reply-To: <52AF4E2C.2060408@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00612.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Monday, December 16, 2013 8:02 PM > >> ... parts look a bit unrelated. It'd be good to have > >> the rationale for this spelled out. I can understand > >> why they might be necessary, but I don't see why > >> target vs non-unwinders unwinders would be special here? > > > > Those changes are not directly related to target vs non-target > > unwinders. They are connected in that they allow new types > > of unwinders. >=20 > > > > I spelled out the rationale for each change in the commit > > message. >=20 > If I missed it, please point me at it. E.g., I didn't see a > rationale for the get_frame_unwind_stop_reason change. > Something like "We need to do X in get_frame_unwind_stop_reason > because otherwise, when we do Y, W doesn't work." I meant that based on your review, I now spell out the rationale for each change in the commit message. I have not sent the updated patch, yet. > > Should I further split this patch into three? >=20 > IMO, yes. OK. I'll do that, as well. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052