From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29582 invoked by alias); 16 Dec 2013 10:53:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29447 invoked by uid 89); 16 Dec 2013 10:53:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Dec 2013 10:53:57 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 16 Dec 2013 02:50:08 -0800 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 16 Dec 2013 02:53:54 -0800 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 16 Dec 2013 10:53:51 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.135]) by IRSMSX151.ger.corp.intel.com ([169.254.4.126]) with mapi id 14.03.0123.003; Mon, 16 Dec 2013 10:53:51 +0000 From: "Metzger, Markus T" To: Pedro Alves , "jan.kratochvil@redhat.com" CC: "gdb-patches@sourceware.org" Subject: RE: [patch v8 17/24] record-btrace: provide xfer_partial target method Date: Mon, 16 Dec 2013 10:53:00 -0000 Message-ID: References: <1386839747-8860-1-git-send-email-markus.t.metzger@intel.com> <1386839747-8860-18-git-send-email-markus.t.metzger@intel.com> <52AB555A.3070301@redhat.com> In-Reply-To: <52AB555A.3070301@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00568.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Friday, December 13, 2013 7:44 PM > I must be missing something, but won't raw_memory_xfer_partial > keep trying in the target beneath, anyway? You're right. This function did not have any effect - and that was good; at least to some extent. Thanks for pointing this out! I changed the return -1 to throw_error (...) and added a check for writebuf !=3D NULL. Suddenly I got tons of errors when GDB can't insert breakpoints any longer for (reverse-)stepping. Also stepping gets broken. I still get the nice for function parameters. This fails already when trying to access the SP for computing the CFA. I now get an error when trying to access a variable with static storage duration or when trying to access memory directly via its address. It would be nice to also get an in those cases. This would require the respective layer to catch my exception. To avoid those errors when trying to set breakpoints, I could try providing to_insert_breakpoint and to_remove_breakpoint methods and maintain my own breakpoints. Breakpoint conditions would still fail. Not sure what else I'm missing. Any better idea? Thanks, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052