From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23448 invoked by alias); 16 Dec 2013 08:40:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23439 invoked by uid 89); 16 Dec 2013 08:40:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Dec 2013 08:40:01 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 16 Dec 2013 00:39:59 -0800 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 16 Dec 2013 00:39:58 -0800 Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 16 Dec 2013 08:39:44 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.135]) by IRSMSX106.ger.corp.intel.com ([169.254.8.15]) with mapi id 14.03.0123.003; Mon, 16 Dec 2013 08:39:30 +0000 From: "Metzger, Markus T" To: Pedro Alves , "gdb-patches@sourceware.org" Subject: RE: [PATCH] "tfind" across unavailable-stack frames. Date: Mon, 16 Dec 2013 08:40:00 -0000 Message-ID: References: <1366214779.30939.1@abidh-ubunto1104> <516F11B9.8030202@redhat.com> <52AB48B6.6040206@redhat.com> In-Reply-To: <52AB48B6.6040206@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00566.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Friday, December 13, 2013 6:50 PM > +/* See frame.h. */ > + > +struct frame_id > +frame_id_build_unavailable_stack (CORE_ADDR code_addr) > +{ > + struct frame_id id =3D null_frame_id; > + > + id.stack_status =3D FID_STACK_UNAVAILABLE; > + id.code_addr =3D code_addr; > + id.code_addr_p =3D 1; > + return id; > +} For record-btrace, we would also need to allow special_addr. I can also add another build function for this case. > struct frame_info; > @@ -97,8 +115,8 @@ struct frame_id > function pointer register or stack pointer register. They are > wrong. >=20 > - This field is valid only if stack_addr_p is true. Otherwise, this > - frame represents the null frame. */ > + This field is valid only if frame_id.stack_status is > + FID_STACK_VALID. */ > CORE_ADDR stack_addr; Maybe the comment should say that this field must be zero unless stack_status =3D=3D FID_STACK_VALID. Frame_id_eq would compare stack_addr if stack_status compares equal. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052