From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23990 invoked by alias); 30 Sep 2013 09:45:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23977 invoked by uid 89); 30 Sep 2013 09:45:25 -0000 Received: from mga03.intel.com (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Sep 2013 09:45:25 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_05,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga03.intel.com Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by azsmga101.ch.intel.com with ESMTP; 30 Sep 2013 02:45:13 -0700 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 30 Sep 2013 02:44:46 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.69]) by IRSMSX102.ger.corp.intel.com ([169.254.2.234]) with mapi id 14.03.0123.003; Mon, 30 Sep 2013 10:44:42 +0100 From: "Metzger, Markus T" To: Jan Kratochvil CC: "gdb-patches@sourceware.org" Subject: RE: [patch v4 18/24] record-btrace: extend unwinder Date: Mon, 30 Sep 2013 09:45:00 -0000 Message-ID: References: <1372842874-28951-1-git-send-email-markus.t.metzger@intel.com> <1372842874-28951-19-git-send-email-markus.t.metzger@intel.com> <20130818190842.GN24153@host2.jankratochvil.net> <20130927135521.GB13376@host2.jankratochvil.net> In-Reply-To: <20130927135521.GB13376@host2.jankratochvil.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg01003.txt.bz2 > -----Original Message----- > From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com] > Sent: Friday, September 27, 2013 3:55 PM > > This has meanwhile been resolved. This had been a side-effect of throw= ing > > an error in to_fetch_registers. When I just return, function arguments= are > > correctly displayed as unavailable and the "can't compute CFA for this > frame" > > message is gone. >=20 > With v6 patchset it is only sometimes gone, I still get it. > Tested with (results are the same): > gcc (GCC) 4.8.2 20130927 (prerelease) > gcc-4.8.1-10.fc21.x86_64 >=20 > int f(int i) { > return i; > } > int main(void) { > f(1); > return 0; > } >=20 > gcc -o test3 test3.c -Wall -g > ./gdb ./test3 -ex start -ex 'record btrace' -ex step -ex step -ex reverse= -step - > ex frame > #0 f (i=3D) at > test3.c:2 > 2 return i; > (gdb) _ >=20 > It gets fixed by the attached patch. Thanks. I'll incorporate it into the extend unwinder patch. Given that we always throw an error for BTRACE frames, there's no need to get the stop reason first or to skip inline frames; they won't be mixed with BTRACE frames. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052