From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4655 invoked by alias); 23 Sep 2013 06:55:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4643 invoked by uid 89); 23 Sep 2013 06:55:43 -0000 Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Sep 2013 06:55:43 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga11.intel.com Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 22 Sep 2013 23:55:41 -0700 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 22 Sep 2013 23:55:39 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.69]) by IRSMSX102.ger.corp.intel.com ([169.254.2.234]) with mapi id 14.03.0123.003; Mon, 23 Sep 2013 07:55:36 +0100 From: "Metzger, Markus T" To: Jan Kratochvil CC: "gdb-patches@sourceware.org" Subject: RE: [patch v4 11/24] record-btrace: supply register target methods Date: Mon, 23 Sep 2013 06:55:00 -0000 Message-ID: References: <1372842874-28951-1-git-send-email-markus.t.metzger@intel.com> <1372842874-28951-12-git-send-email-markus.t.metzger@intel.com> <20130818190727.GI24153@host2.jankratochvil.net> <20130922135527.GA19149@host2.jankratochvil.net> In-Reply-To: <20130922135527.GA19149@host2.jankratochvil.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00808.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Jan Kratochvil > > > Here should be rather: > > > gdb_assert (may_write_registers =3D=3D 0); > > > > > > as target_store_registers() would not pass the call here otherwise. > > > > I took this from target_store_registers in target.c. >=20 > But that is a different case. The case 'may_write_registers =3D=3D 0' is= always > already caught by target_store_registers(). record_btrace_store_register= s() > gets called only by target_store_registers() which already verified the > variable is not zero. OK. Changed it. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052