From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11205 invoked by alias); 16 Sep 2013 09:30:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11196 invoked by uid 89); 16 Sep 2013 09:30:55 -0000 Received: from mga03.intel.com (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Sep 2013 09:30:55 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga03.intel.com Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga101.ch.intel.com with ESMTP; 16 Sep 2013 02:30:51 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by AZSMGA002.ch.intel.com with ESMTP; 16 Sep 2013 02:30:50 -0700 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 16 Sep 2013 10:30:49 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.69]) by IRSMSX153.ger.corp.intel.com ([169.254.9.47]) with mapi id 14.03.0123.003; Mon, 16 Sep 2013 10:30:49 +0100 From: "Metzger, Markus T" To: Jan Kratochvil CC: "gdb-patches@sourceware.org" Subject: RE: [patch v4 14/24] record-btrace: provide xfer_partial target method Date: Mon, 16 Sep 2013 09:30:00 -0000 Message-ID: References: <1372842874-28951-1-git-send-email-markus.t.metzger@intel.com> <1372842874-28951-15-git-send-email-markus.t.metzger@intel.com> <20130818190753.GK24153@host2.jankratochvil.net> In-Reply-To: <20130818190753.GK24153@host2.jankratochvil.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00431.txt.bz2 > -----Original Message----- > From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com] > Sent: Sunday, August 18, 2013 9:08 PM Thanks for your review. > > +static LONGEST > > +record_btrace_xfer_partial (struct target_ops *ops, enum target_object > object, > > + const char *annex, gdb_byte *readbuf, > > + const gdb_byte *writebuf, ULONGEST offset, > > + LONGEST len) > > +{ > > + struct target_ops *t; > > + > > + /* Normalize the request so len is positive. */ if (len < 0) > > + { > > + offset +=3D len; > > + len =3D - len; > > + } >=20 > I do not see LEN could be < 0, do you? Use just: > gdb_assetr (len >=3D 0); > (It even should never be LEN =3D=3D 0 but that may not be guaranteed.) Hmm, why didn't we use ULONGEST, then? It looks like all implementations in target.c assume LEN to be positive wit= hout checking. I'm doing the same. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052