From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27692 invoked by alias); 10 Sep 2013 13:06:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27680 invoked by uid 89); 10 Sep 2013 13:06:09 -0000 Received: from mga14.intel.com (HELO mga14.intel.com) (143.182.124.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Sep 2013 13:06:09 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga14.intel.com Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by azsmga102.ch.intel.com with ESMTP; 10 Sep 2013 06:06:05 -0700 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 10 Sep 2013 06:06:04 -0700 Received: from irsmsx105.ger.corp.intel.com (163.33.3.28) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 10 Sep 2013 14:06:01 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.69]) by IRSMSX105.ger.corp.intel.com ([169.254.7.29]) with mapi id 14.03.0123.003; Tue, 10 Sep 2013 14:06:00 +0100 From: "Metzger, Markus T" To: Jan Kratochvil CC: "gdb-patches@sourceware.org" , "Himpel, Christian" Subject: RE: [patch v4 07/24] record-btrace: optionally indent function call history Date: Tue, 10 Sep 2013 13:06:00 -0000 Message-ID: References: <1372842874-28951-1-git-send-email-markus.t.metzger@intel.com> <1372842874-28951-8-git-send-email-markus.t.metzger@intel.com> <20130818190623.GF24153@host2.jankratochvil.net> In-Reply-To: <20130818190623.GF24153@host2.jankratochvil.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00333.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Jan Kratochvil > Sent: Sunday, August 18, 2013 9:06 PM Thanks for your review. > > + else > > + ui_out_field_string (uiout, "function", ""); >=20 > Here should be _(""). (BTW I do not know about any existing > localized message catalogs for GDB.) >=20 > _() would be inappropriate for MI but in such case there should be IMO > anyway > rather: >=20 > else if (!ui_out_is_mi_like_p (uiout)) > ui_out_field_string (uiout, "function", _("")); >=20 > But there is currently no MI interface setup for these commands (although > you have nicely prepared the commands for MI) so I do not find it worth t= he > time to discuss MI issues now. I changed it like you proposed above with no output for MI. What should we do with text output like "inst" and "at" below. > > + ui_out_text (uiout, "\tinst "); Would I split this to separate "inst" from the formatting? Or is it OK to just say '_("\tinst ")'? Thanks, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052