From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24673 invoked by alias); 26 Mar 2013 07:46:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24647 invoked by uid 89); 26 Mar 2013 07:46:17 -0000 X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 26 Mar 2013 07:46:13 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 26 Mar 2013 00:46:11 -0700 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 26 Mar 2013 00:46:10 -0700 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.1.355.2; Tue, 26 Mar 2013 07:46:10 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.244]) by IRSMSX151.ger.corp.intel.com ([169.254.4.245]) with mapi id 14.01.0355.002; Tue, 26 Mar 2013 07:46:09 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: GDB Patches Subject: RE: "set record instruction-history" ? Date: Tue, 26 Mar 2013 16:21:00 -0000 Message-ID: References: <51507403.6030208@redhat.com> <51508D60.6040906@redhat.com> In-Reply-To: <51508D60.6040906@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-03/txt/msg00963.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Monday, March 25, 2013 6:46 PM > To: Metzger, Markus T > +static void > +validate_positive_integer (int *command_var, int *setting) > +{ > + if (*command_var < 0) > + { > + int var =3D *command_var; > + > + /* Restore previous value. */ > + *command_var =3D *setting; > + error (_("integer %d out of range"), var); > + } > + > + /* Commit new value. */ > + *setting =3D *command_var; > +} Shouldn't we map 0 to INT_MAX before committing the new value? The functionality should be covered by the gdb.btrace test suite. Do you w= ant to commit your patch or do you want me to test and then commit it? Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052