From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7409 invoked by alias); 7 Mar 2013 07:50:22 -0000 Received: (qmail 7401 invoked by uid 22791); 7 Mar 2013 07:50:21 -0000 X-SWARE-Spam-Status: No, hits=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Mar 2013 07:50:15 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 06 Mar 2013 23:50:14 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga002.fm.intel.com with ESMTP; 06 Mar 2013 23:50:01 -0800 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.1.355.2; Thu, 7 Mar 2013 07:49:59 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.244]) by IRSMSX151.ger.corp.intel.com ([169.254.4.245]) with mapi id 14.01.0355.002; Thu, 7 Mar 2013 07:49:59 +0000 From: "Metzger, Markus T" To: Doug Evans CC: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" Subject: RE: [patch v9 01/23] thread, btrace: add generic branch trace support Date: Thu, 07 Mar 2013 07:50:00 -0000 Message-ID: References: <1362416770-19750-1-git-send-email-markus.t.metzger@intel.com> <1362416770-19750-2-git-send-email-markus.t.metzger@intel.com> In-Reply-To: Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00262.txt.bz2 > -----Original Message----- > From: Doug Evans [mailto:dje@google.com] > Sent: Wednesday, March 06, 2013 10:12 PM Thanks for your review. > > + /* The function index range [begin; end[ that has been covered last= time. >=20 > Typo: end] That's intended to indicate that begin is included in the range whereas end= isn't. I see that this has not been clear enough. I'll reword it. > > +/* A branch trace block. > > + > > + This represents a block of sequential control-flow. Adjacent bloc= ks will be > > + connected via calls, returns, or jumps. The latter can be direct = or > > + indirect, conditional or unconditional. Branches can further be > > + asynchronous, e.g. interrupts. */ > > +struct btrace_block > > +{ > > + /* The address of the first instruction in the block. */ > > + CORE_ADDR begin; > > + > > + /* The address of the last instruction in the block. */ > > + CORE_ADDR end; > > +}; >=20 > Can you elaborate in the docs for "end" what it is? > E.g., on an ISA with only 4 byte instructions, and the block contains > two instructions, is end =3D=3D begin+4 or begin+7 or begin+8? > I'd guess that it's begin+4, but IWBN if the comment > removed all doubt. I changed both comments to say "the first byte of ...". Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052