From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30068 invoked by alias); 1 Mar 2013 14:07:13 -0000 Received: (qmail 30060 invoked by uid 22791); 1 Mar 2013 14:07:12 -0000 X-SWARE-Spam-Status: No, hits=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Mar 2013 14:07:05 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 01 Mar 2013 06:07:02 -0800 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 01 Mar 2013 06:06:51 -0800 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.1.355.2; Fri, 1 Mar 2013 14:06:24 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.108]) by IRSMSX152.ger.corp.intel.com ([169.254.6.135]) with mapi id 14.01.0355.002; Fri, 1 Mar 2013 14:06:23 +0000 From: "Metzger, Markus T" To: Eli Zaretskii CC: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH 3/3] doc, record: document record changes Date: Fri, 01 Mar 2013 14:07:00 -0000 Message-ID: References: <1361808917-16934-1-git-send-email-markus.t.metzger@intel.com> <1361808917-16934-4-git-send-email-markus.t.metzger@intel.com> <838v6bhttl.fsf@gnu.org> In-Reply-To: <838v6bhttl.fsf@gnu.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00016.txt.bz2 > -----Original Message----- > From: Eli Zaretskii [mailto:eliz@gnu.org] > Sent: Tuesday, February 26, 2013 6:24 PM > To: Metzger, Markus T Thanks for your review. > [May I ask that you use your address fewer than 3 times in the headers?] I reduced it by one. > > +"record function-call-history" prints the names of the functions > > +from instructions stored in the execution log. >=20 > "prints the names of the functions called by instructions in the > execution log" I'm not sure whether "called" is the right term. The algorithm walks over all instructions and collects the functions from which these instructions originated. Example: 1 void foo (void) 2 { 3 ... 4 bar (); 5 ... 6 } When we record the execution of foo, there will be instructions for the first ..., then instructions for bar, and then instructions for the second = .... The "record function-call-history" will print: foo.c:1-4 foo (void) bar.c:8-12 bar (void) foo.c:5-6 foo (void > > +@kindex show record full memory-query > > +@item show record full memory-query >=20 > I think it is good enough to have only one "@kindex set record" and > one "@kindex show record" entry (which you already have at the > beginning of this description), without the entries that advertise the > rest of the command arguments. These varieties are all described > together, so the multitude of index entries does not have any useful > effect, it just bloats the index. I just renamed the text for existing indices. Do you still want me to merge them? > > +@item record function-call-history > > +Print function names for instructions stored in the recorded execution > > +log. Prints one line for each sequence of instructions that is > > +correlated to the same function. >=20 > Isn't the last sentence equivalent to saying >=20 > Prints one line for each function call in the execution log. >=20 > ? If it is equivalent, I think my suggested wording is more clear and > less technical. See above. Thanks, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052