From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31443 invoked by alias); 18 Dec 2012 09:11:23 -0000 Received: (qmail 31422 invoked by uid 22791); 18 Dec 2012 09:11:22 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 09:11:15 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 18 Dec 2012 01:11:11 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 18 Dec 2012 01:11:09 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX103.ger.corp.intel.com ([169.254.3.74]) with mapi id 14.01.0355.002; Tue, 18 Dec 2012 09:11:07 +0000 From: "Metzger, Markus T" To: Jan Kratochvil CC: "palves@redhat.com" , "tromey@redhat.com" , "kettenis@gnu.org" , "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" Subject: RE: [patch v6 02/12] cli, btrace: add btrace cli Date: Tue, 18 Dec 2012 09:11:00 -0000 Message-ID: References: <1355760101-26237-1-git-send-email-markus.t.metzger@intel.com> <1355760101-26237-3-git-send-email-markus.t.metzger@intel.com> <20121218090428.GE8054@host2.jankratochvil.net> In-Reply-To: <20121218090428.GE8054@host2.jankratochvil.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00626.txt.bz2 > -----Original Message----- > From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com] > Sent: Tuesday, December 18, 2012 10:04 AM > To: Metzger, Markus T > Cc: palves@redhat.com; tromey@redhat.com; kettenis@gnu.org; gdb-patches@s= ourceware.org; markus.t.metzger@gmail.com > Subject: Re: [patch v6 02/12] cli, btrace: add btrace cli >=20 > Hi Markus, >=20 > I find new class excessive, feature specific to a single arch has a new "= help" > main menu entry now. For example existing - more powerful "record" featu= re is > now under class_obscure. Maybe it could be class_run but so far I would = put > it together to "record", that is a bit unfortunate class_obscure. OK, I'll change the class to class_obscure. Regards, Markus. >=20 >=20 > Thanks, > Jan >=20 >=20 > On Mon, 17 Dec 2012 17:01:31 +0100, markus.t.metzger@intel.com wrote: > > diff --git a/gdb/command.h b/gdb/command.h > > index 8eb86ba..b576b70 100644 > > --- a/gdb/command.h > > +++ b/gdb/command.h > > @@ -39,7 +39,7 @@ enum command_class > > no_class =3D -1, class_run =3D 0, class_vars, class_stack, class_fil= es, > > class_support, class_info, class_breakpoint, class_trace, > > class_alias, class_bookmark, class_obscure, class_maintenance, > > - class_pseudo, class_tui, class_user, class_xdb, > > + class_pseudo, class_tui, class_user, class_xdb, class_btrace, > > no_set_class /* Used for "show" commands that have no corresponding > > "set" command. */ > > }; > > diff --git a/gdb/testsuite/gdb.base/page.exp b/gdb/testsuite/gdb.base/p= age.exp > > index 0629807..d9b3899 100644 > > --- a/gdb/testsuite/gdb.base/page.exp > > +++ b/gdb/testsuite/gdb.base/page.exp > > @@ -25,6 +25,7 @@ gdb_test_sequence "help" "unpaged help" { > > "List of classes of commands:" > > "" > > "aliases -- Aliases of other commands" > > + "branchtrace -- Recording a branch trace" > > "breakpoints -- Making program stop at certain points" > > "data -- Examining data" > > "files -- Specifying and examining files" > > @@ -52,12 +53,12 @@ gdb_expect_list "paged help" \ > > "List of classes of commands:" > > "" > > "aliases -- Aliases of other commands" > > + "branchtrace -- Recording a branch trace" > > "breakpoints -- Making program stop at certain points" > > "data -- Examining data" > > "files -- Specifying and examining files" > > "internals -- Maintenance commands" > > "obscure -- Obscure features" > > - "running -- Running the program" > > } > > gdb_test "q" > > > > -- > > 1.7.6.5 Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052