From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25747 invoked by alias); 18 Dec 2012 07:36:57 -0000 Received: (qmail 25635 invoked by uid 22791); 18 Dec 2012 07:36:55 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga03.intel.com (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 07:36:52 +0000 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 17 Dec 2012 23:36:51 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by azsmga001.ch.intel.com with ESMTP; 17 Dec 2012 23:36:49 -0800 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.1.355.2; Tue, 18 Dec 2012 07:36:48 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX152.ger.corp.intel.com ([169.254.6.36]) with mapi id 14.01.0355.002; Tue, 18 Dec 2012 07:36:48 +0000 From: "Metzger, Markus T" To: Jan Kratochvil CC: "palves@redhat.com" , "tromey@redhat.com" , "kettenis@gnu.org" , "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" Subject: RE: [patch v6 02/12] cli, btrace: add btrace cli Date: Tue, 18 Dec 2012 07:36:00 -0000 Message-ID: References: <1355760101-26237-1-git-send-email-markus.t.metzger@intel.com> <1355760101-26237-3-git-send-email-markus.t.metzger@intel.com> <20121217183214.GA14232@host2.jankratochvil.net> In-Reply-To: <20121217183214.GA14232@host2.jankratochvil.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00616.txt.bz2 > -----Original Message----- > From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com] > Sent: Monday, December 17, 2012 7:32 PM Thanks for your review. [...] > > + if (trace->end < trace->begin) > > + warning (_("Bad trace: %s - %s"), paddress (gdbarch, trace->begin), > > + paddress (gdbarch, trace->end)); >=20 > Shouldn't this be rather gdb_assert? How to create such case? I have not seen such a case, yet. This would indicate some corrupted trace = buffer or problems reading the trace data correctly. It should normally not= happen. I didn't use gdb_assert since this is not checking gdb's internal state. Gd= b would still function correctly even if we saw such unexpected trace. I'm OK to change it to gdb_assert, if you want. > No need for a repost wrt the changes above. Does that mean you approve the patch? Thanks, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052