From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10708 invoked by alias); 13 Dec 2012 09:14:30 -0000 Received: (qmail 10696 invoked by uid 22791); 13 Dec 2012 09:14:28 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Dec 2012 09:14:23 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 13 Dec 2012 01:14:21 -0800 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 13 Dec 2012 01:14:19 -0800 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.1.355.2; Thu, 13 Dec 2012 09:14:18 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX152.ger.corp.intel.com ([169.254.6.36]) with mapi id 14.01.0355.002; Thu, 13 Dec 2012 09:14:18 +0000 From: "Metzger, Markus T" To: Eli Zaretskii CC: "gdb-patches@sourceware.org" , "jan.kratochvil@redhat.com" , "palves@redhat.com" , "tromey@redhat.com" , "kettenis@gnu.org" Subject: RE: [patch v5 02/12] cli, btrace: add btrace cli Date: Thu, 13 Dec 2012 09:14:00 -0000 Message-ID: References: <1354876644-25749-1-git-send-email-markus.t.metzger@intel.com> <1354876644-25749-3-git-send-email-markus.t.metzger@intel.com> <8338zhopuk.fsf@gnu.org> In-Reply-To: <8338zhopuk.fsf@gnu.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00432.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourcewa= re.org] On Behalf Of Eli Zaretskii > Sent: Friday, December 07, 2012 4:16 PM Thanks for your review. [...] > > Add branch trace commands: >=20 > Thanks. This will be documented at some point, yes? Yes. I will start it shortly. > > + add_cmd ("list", class_btrace, cmd_btrace_list, _("\ > > +List branch trace blocks.\n\n\ > > +Prints a list of all blocks for which branch trace is available.\n\ >=20 > "Print", not "prints", to be compatible with "List". Fixed. > > +With a /a modifier, addresses are included.\n\ > > +With a /f modifier, the function name is included (if available).\n\ >=20 > It is better to use active tense, not passive tense: >=20 > With a /a modifier, include addresses. > With a /f modifier, include function names (if available). I changed this for all command texts. =20 > > +With a /l modifier, source lines are include (if available).\n\ > ^^^^^^^ > A typo. Changed to active tense. > > +With a /t modifier, prints the total number of trace blocks and stops.= \n\ > ^^^^^^ > "print" Fixed. Everywhere. > > +Without any modifier, behaves as if /fl were specified.\n\n\ >=20 > By default, include function names and source lines. Fixed. > And I have a question: how to turn off all the optional print-outs? > Is there a /no-f modifier or something? No, there isn't. Everything is optional, except for the block number. If yo= u wanted to turn off everything, you would get a list of integers, which wo= uld be fairly useless. You can get the total number of blocks using /t. > > +Without arguments, the full list of blocks is listed.\n\ > > +With a range ([-]) argument, lists all blocks in that rang= e.\n"), >=20 > Again, use active tense, and "list" instead of "lists". Fixed. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052