From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7349 invoked by alias); 6 Dec 2012 10:15:42 -0000 Received: (qmail 7339 invoked by uid 22791); 6 Dec 2012 10:15:41 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Dec 2012 10:15:30 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 06 Dec 2012 02:15:30 -0800 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 06 Dec 2012 02:15:28 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX101.ger.corp.intel.com ([169.254.1.13]) with mapi id 14.01.0355.002; Thu, 6 Dec 2012 10:15:22 +0000 From: "Metzger, Markus T" To: Jan Kratochvil CC: "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" , "palves@redhat.com" , "tromey@redhat.com" , "kettenis@gnu.org" Subject: RE: [patch v4 13/13] btrace, x86: restrict to Atom Date: Thu, 06 Dec 2012 10:15:00 -0000 Message-ID: References: <1354013351-14791-1-git-send-email-markus.t.metzger@intel.com> <1354013351-14791-14-git-send-email-markus.t.metzger@intel.com> <20121127130500.GA22431@host2.jankratochvil.net> <20121127142904.GA30650@host2.jankratochvil.net> In-Reply-To: <20121127142904.GA30650@host2.jankratochvil.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00106.txt.bz2 > -----Original Message----- > From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com] > Sent: Tuesday, November 27, 2012 3:29 PM > To: Metzger, Markus T > Cc: gdb-patches@sourceware.org; markus.t.metzger@gmail.com; palves@redhat= .com; tromey@redhat.com; kettenis@gnu.org > Subject: Re: [patch v4 13/13] btrace, x86: restrict to Atom >=20 > On Tue, 27 Nov 2012 15:03:48 +0100, Metzger, Markus T wrote: > > > There is i386-nat.c for the common functions between these two files. > > > > Is it OK put Linux specific code into i386-nat.c? >=20 > True it is not so clear, it would be OK as long as the linux_supports_btr= ace() > call is moved out of it, as otherwise it just checks the CPU hardware fea= ture. >=20 > But as you use it also in gdbserver I see now it can be moved to > common/linux-btrace.[ch] with appropriate #ifdef __i386__ and __x86_64__. > common/ currently does not have any per-file arch/target configury like g= db/ > and gdbserver/ have, one day it will probably have it but not now. Pedro seems OK with this, as well. It simplifies the patch a lot. Thanks fo= r pointing this out. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052