From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17474 invoked by alias); 30 Nov 2012 15:23:52 -0000 Received: (qmail 17464 invoked by uid 22791); 30 Nov 2012 15:23:51 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Nov 2012 15:23:45 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 30 Nov 2012 07:23:43 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga002.fm.intel.com with ESMTP; 30 Nov 2012 07:23:42 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX103.ger.corp.intel.com ([169.254.3.74]) with mapi id 14.01.0355.002; Fri, 30 Nov 2012 15:23:28 +0000 From: "Metzger, Markus T" To: Jan Kratochvil CC: Tom Tromey , "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" , "palves@redhat.com" , "kettenis@gnu.org" Subject: RE: [patch v4 03/13] cli, btrace: add btrace cli Date: Fri, 30 Nov 2012 15:23:00 -0000 Message-ID: References: <1354013351-14791-1-git-send-email-markus.t.metzger@intel.com> <1354013351-14791-4-git-send-email-markus.t.metzger@intel.com> <87k3t6btlo.fsf@fleche.redhat.com> <20121130151603.GA8422@host2.jankratochvil.net> In-Reply-To: <20121130151603.GA8422@host2.jankratochvil.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00935.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourcewa= re.org] On Behalf Of Jan Kratochvil > Sent: Friday, November 30, 2012 4:16 PM > To: Metzger, Markus T > Cc: Tom Tromey; gdb-patches@sourceware.org; markus.t.metzger@gmail.com; p= alves@redhat.com; kettenis@gnu.org > Subject: Re: [patch v4 03/13] cli, btrace: add btrace cli >=20 > On Fri, 30 Nov 2012 16:09:02 +0100, Metzger, Markus T wrote: > > The easiest thing for me to do would be to only print "()" if lang !=3D > > language_cplus. Since the demangler prints the parameters right after t= he > > function name, though, I would also remove the space before "()" for ot= her > > languages. >=20 > http://www.gnu.org/prep/standards/standards.html#GNU-Manuals > Please do not write '()' after a function name just to indicate it is > a function. foo () is not a function, it is a function call with no > arguments. In that case, I would just drop the "()" altogether and print whatever SYMB= OL_PRINT_NAME returns. Thanks, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052