From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22044 invoked by alias); 28 Nov 2012 14:44:31 -0000 Received: (qmail 22031 invoked by uid 22791); 28 Nov 2012 14:44:29 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,TW_BJ X-Spam-Check-By: sourceware.org Received: from mga14.intel.com (HELO mga14.intel.com) (143.182.124.37) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 14:44:20 +0000 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 28 Nov 2012 06:44:19 -0800 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by azsmga001.ch.intel.com with ESMTP; 28 Nov 2012 06:44:18 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX104.ger.corp.intel.com ([169.254.5.151]) with mapi id 14.01.0355.002; Wed, 28 Nov 2012 14:44:16 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" , "jan.kratochvil@redhat.com" , "tromey@redhat.com" , "kettenis@gnu.org" Subject: RE: [patch v4 01/13] disas: add precise instructions flag Date: Wed, 28 Nov 2012 14:44:00 -0000 Message-ID: References: <1354013351-14791-1-git-send-email-markus.t.metzger@intel.com> <1354013351-14791-2-git-send-email-markus.t.metzger@intel.com> <50B4EF0E.8080102@redhat.com> <50B4F968.8080202@redhat.com> In-Reply-To: <50B4F968.8080202@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00810.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Tuesday, November 27, 2012 6:33 PM > To: Metzger, Markus T > Cc: gdb-patches@sourceware.org; markus.t.metzger@gmail.com; jan.kratochvi= l@redhat.com; tromey@redhat.com; > kettenis@gnu.org > Subject: Re: [patch v4 01/13] disas: add precise instructions flag >=20 > On 11/27/2012 05:26 PM, Metzger, Markus T wrote: >=20 > >> From: Pedro Alves [mailto:palves@redhat.com] >=20 > >>> the addresses that > >>> are being disassembled may not exactly match the specified range. > >> > >> Is this another symptom of the issue that "disasm /m" sorts by > >> line number, rather than the much more reasonable sort-by-address, > >> which is IIRC what objdump does too? > > > > Yes. I didn't want to go that far. > > > > The patch is incomplete. It merely truncates the first and last block t= hat gdb prints. If you wanted to change the behavior of "disasm > /m", anyway, we can discard this patch. Sort-by-address is exactly what I= 'm looking for. Is somebody already working on this? >=20 > I've never heard of anyone who actually likes the current behavior. On t= he > contrary, I've heard several of the gdb developers wanting it the other w= ay. > But I'm not aware of anyone working on it. I'm not sure how hard is it > to implement. Both gdb and objdump use libopcodes to disassemble, so > one would think that it's quite doable. I think a wrinkle may be that > the TUI uses the same code and the current sorting may (or not) make sens= e there > I think the /m flag was just implemented as reusing the TUI code to begin= with. My test suite does not depend on it. I just noticed it when I used the feat= ure. I'll drop this patch and look into fixing "disasm /m", instead. Thanks, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Peter Gleissner, Christian Lamprechter, Hannes Schwadere= r, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052