From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16510 invoked by alias); 12 Sep 2012 08:34:52 -0000 Received: (qmail 16451 invoked by uid 22791); 12 Sep 2012 08:34:51 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Sep 2012 08:34:38 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 12 Sep 2012 01:34:33 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 12 Sep 2012 01:34:29 -0700 Received: from irsmsx104.ger.corp.intel.com (163.33.3.159) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.1.355.2; Wed, 12 Sep 2012 09:34:27 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.34]) by IRSMSX104.ger.corp.intel.com ([169.254.5.154]) with mapi id 14.01.0355.002; Wed, 12 Sep 2012 09:34:24 +0100 From: "Metzger, Markus T" To: Tom Tromey CC: "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" , "jan.kratochvil@redhat.com" , "palves@redhat.com" , "kettenis@gnu.org" Subject: RE: [patch v3 03/16] source: add flags to print_source_lines () Date: Wed, 12 Sep 2012 08:34:00 -0000 Message-ID: References: <1344949171-9545-1-git-send-email-markus.t.metzger@intel.com> <1344949171-9545-4-git-send-email-markus.t.metzger@intel.com> <87k3w08gi5.fsf@fleche.redhat.com> In-Reply-To: <87k3w08gi5.fsf@fleche.redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00193.txt.bz2 > -----Original Message----- > From: Tom Tromey [mailto:tromey@redhat.com] > Sent: Tuesday, September 11, 2012 10:14 PM > To: Metzger, Markus T > Cc: gdb-patches@sourceware.org; markus.t.metzger@gmail.com; jan.kratochvi= l@redhat.com; palves@redhat.com; > kettenis@gnu.org > Subject: Re: [patch v3 03/16] source: add flags to print_source_lines () >=20 > >>>>> "Markus" =3D=3D markus t metzger write= s: >=20 > Markus> 2012-08-14 Markus Metzger > Markus> * symtab.h (print_source_lines_flags): New enum. > Markus> * source.c (print_source_lines_base): Change noerror to flags. > Markus> (print_source_lines): Change noerror to flags. >=20 > This is ok. I think it is fine to put it in immediately if you want. Thanks. I'll commit patches 1, 3, and 4, then, as soon as I my write-after-= approval request has been granted. How about patch 2? Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Peter Gleissner, Christian Lamprechter, Hannes Schwadere= r, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052