> -----Original Message----- > From: Metzger, Markus T > Sent: Monday, June 25, 2012 10:50 AM [...] > > Markus> - "btrace enable/disable" perform the obvious operation > > > > I think it may be more "gdb-ish" to make this a set/show option, by > > analogy with "set stop-on-solib-events" and the like. > > > > This would give users a way to see whether it is currently enabled, as > > well. > > You mean something like "set btrace on"? I looked at some other gdb commands with related behavior. Tracepoints uses tstart/tstop; record uses record/record stop. Record uses set/show for configuration options. By analogy, this could be used for configuring the size of the trace buffer. Or it could be used to turn automatic enabling on and off. Set typically changes some global setting, whereas the btrace enable/disable commands operate on the current thread or a range of threads. It might make sense to turn "btrace enable/disable auto" into "set btrace auto on/off". But I would leave the "btrace enable/disable" commands, as they are - or maybe rename them into "btrace start/stop". [...] Regards, markus.