From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15729 invoked by alias); 18 Sep 2018 09:08:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15702 invoked by uid 89); 18 Sep 2018 09:08:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0071.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.71) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 09:08:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pkwATt2uHsp8A1eHd8sQRe3BUquwhkR4Z9Un2G9rkFE=; b=KDJ6Gl+0V6z/ibbYsD2Hnasg2NB98LzyiwgzQdU7BbHiAp+we3Fi3GeC0Hkzt5M54U3TIO4EbhV+mUj/ff+tSl2c3korVobqlrX77SzeudSJYeauWX6+bKHlg0Ur7iLULwWSyC8bVAtde6J8ZAE4fSK1mExVFg7FLQgtuBMaeeE= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2136.eurprd08.prod.outlook.com (10.172.226.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Tue, 18 Sep 2018 09:08:39 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::7073:f11c:4e4:cb13]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::7073:f11c:4e4:cb13%4]) with mapi id 15.20.1143.017; Tue, 18 Sep 2018 09:08:39 +0000 From: Alan Hayward To: Joel Brobecker CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Aarch64 SVE: Fix stack smashing when calling functions Date: Tue, 18 Sep 2018 09:08:00 -0000 Message-ID: References: <20180917144540.78906-1-alan.hayward@arm.com> <20180917184205.GG19172@adacore.com> In-Reply-To: <20180917184205.GG19172@adacore.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <969A402B9504B44FAD2D1F33C9E13E40@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00621.txt.bz2 DQoNCj4gT24gMTcgU2VwIDIwMTgsIGF0IDE5OjQyLCBKb2VsIEJyb2JlY2tl ciA8YnJvYmVja2VyQGFkYWNvcmUuY29tPiB3cm90ZToNCj4gDQo+IEhpIEFs YW4sDQo+IA0KPj4gVXNpbmcgImNhbGwiIG9uIGEgZnVuY3Rpb24gdGhhdCBw YXNzZXMgYXJndW1lbnRzIHZpYSBmbG9hdCByZWdpc3RlcnMgY2FuIGNhdXNl DQo+PiBnZGIgdG8gb3ZlcmZsb3cgYnVmZmVycy4NCj4gDQo+PiBFbnN1cmUg ZW5vdWdoIG1lbW9yeSBpcyByZXNlcnZlZCB0byBob2xkIGEgZnVsbCBGUCBy ZWdpc3Rlci4NCj4+IA0KPj4gMjAxOC0wOS0xNyAgQWxhbiBIYXl3YXJkICA8 YWxhbi5oYXl3YXJkQGFybS5jb20+DQo+PiANCj4+IAkqIGFhcmNoNjQtdGRl cC5jIChwYXNzX2luX3YpOiBVc2UgcmVnaXN0ZXIgc2l6ZS4NCj4+IAkoYWFy Y2g2NF9leHRyYWN0X3JldHVybl92YWx1ZSk6IExpa2V3aXNlLg0KPj4gCShh YXJjaDY0X3N0b3JlX3JldHVybl92YWx1ZSk6IExpa2V3aXNlLg0KPiANCj4g RG8gd2UgaGF2ZSBhIHRlc3RjYXNlIGFscmVhZHkgdGhhdCBkZW1vbnN0cmF0 ZXMgdGhlIHByb2JsZW0/DQo+IE90aGVyd2lzZSwgaXQgd291bGQgYmUgbmlj ZSB0byBhZGQgb25lLg0KDQpJIHNob3VsZCBoYXZlIG1lbnRpb25lZCB0aGF0 IGluIHRoZSBkZXNjcmlwdGlvbi4gSSBjYW4gYWRkOg0K4oCcVGhpcyBmaXhl cyBnZGIuYmFzZS9jYWxsZnVuY3MuZXhwIGZvciBBYXJjaDY0IFNWRS4iDQoN Cj4gDQo+PiBkaWZmIC0tZ2l0IGEvZ2RiL2FhcmNoNjQtdGRlcC5jIGIvZ2Ri L2FhcmNoNjQtdGRlcC5jDQo+PiBpbmRleCA2OTkzZTkwNjFlLi41MTZlYjEz OGRjIDEwMDY0NA0KPj4gLS0tIGEvZ2RiL2FhcmNoNjQtdGRlcC5jDQo+PiAr KysgYi9nZGIvYWFyY2g2NC10ZGVwLmMNCj4+IEBAIC0xMzU4LDcgKzEzNTgs MTAgQEAgcGFzc19pbl92IChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwNCj4+ ICAgaWYgKGluZm8tPm5zcm4gPCA4KQ0KPj4gICAgIHsNCj4+ICAgICAgIGlu dCByZWdudW0gPSBBQVJDSDY0X1YwX1JFR05VTSArIGluZm8tPm5zcm47DQo+ PiAtICAgICAgZ2RiX2J5dGUgcmVnW1ZfUkVHSVNURVJfU0laRV07DQo+PiAr ICAgICAgLyogRW5vdWdoIHNwYWNlIGZvciBhIGZ1bGwgdmVjdG9yIHJlZ2lz dGVyLiAgKi8NCj4+ICsgICAgICBnZGJfYnl0ZSByZWdbcmVnaXN0ZXJfc2l6 ZSAoZ2RiYXJjaCwgcmVnbnVtKV07DQo+PiArICAgICAgZ2RiX3N0YXRpY19h c3NlcnQgKEFBUkNINjRfVjBfUkVHTlVNID09IEFBUkNINjRfU1ZFX1owX1JF R05VTSk7DQo+PiArICAgICAgZ2RiX2Fzc2VydCAobGVuIDw9IHNpemVvZiAo cmVnKSk7DQo+IA0KPiBDb3VsZCB5b3UgZXhwbGFpbiB0aGUgcmVsYXRpb25z aGlwIGJldHdlZW4gbWFraW5nIHRoZSBidWZmZXIgbGFyZ2UNCj4gZW5vdWdo LCB3aGljaCBpcyB0aGUgcHVycG9zZSBvZiB0aGlzIHBhdGNoLCBhbmQgdGhl IGFzc2VydGlvbiB0aGF0DQo+IEFBUkNINjRfVjBfUkVHTlVNID09IEFBUkNI NjRfU1ZFX1owX1JFR05VTT8NCj4gDQo+IEkgZG9uJ3Qgc2VlIGEgcHJvYmxl bSB3aXRoIHRoYXQgYXNzZXJ0aW9uLCBidXQgZm9yIGFyY2hlb2xvZ3kNCj4g cHVycG9zZXMsIGl0IGlzIGJldHRlciB0byBkZWNvcmVsYXRlIGNoYW5nZXMg dGhhdCBhcmUgaW5kZXBlbmRlbnQuDQo+IEl0IGhlbHBzIGJldHRlciBkb2N1 bWVudCB3aHkgd2UgaW50cm9kdWNlZCBjaGFuZ2VzLg0KDQpUaGlua2luZyBh Ym91dCBpdCwgdGhhdCBhc3NlcnQgc2hvdWxkIGJlIHJlbW92ZWQuDQpJIHdh cyByZXVzaW5nIHRocmVlIGxpbmVzIGZyb20gYWFyY2g2NF9wc2V1ZG9fcmVh ZF92YWx1ZV8xLCB3aGljaA0KcGFzc2VkIEFBUkNINjRfVjBfUkVHTlVNIGlu dG8gcmVnaXN0ZXJfc2l6ZS4gVGhlcmUgdGhlIGFzc2VydCBtYWRlDQpzZW5z ZS4gV2hlbiBJIHN3aXRjaGVkIHRvIHVzZSByZWdudW0gSSBkaWRu4oCZdCBy ZXRoaW5rIHRoZSBhc3NlcnQuDQoNCknigJlsbCByZW1vdmUgdGhlIHRocmVl IG5ldyBpbnN0YW5jZXMgb2YgdGhhdCBhc3NlcnQgZnJvbSB0aGlzIHBhdGNo Lg0KDQpBcmUgeW91IGhhcHB5IHdpdGggdGhvc2UgdGhvc2UgY2hhbmdlcz8N Cg0KDQpUaGFua3MsDQpBbGFuLg0KDQoNCg== >From gdb-patches-return-150957-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Sep 18 09:52:41 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 47243 invoked by alias); 18 Sep 2018 09:52:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 47218 invoked by uid 89); 18 Sep 2018 09:52:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*rth, HX-Received:sk:b10-v6m, Hx-spam-relays-external:209.85.214.194, H*RU:209.85.214.194 X-HELO: mail-pl1-f194.google.com Received: from mail-pl1-f194.google.com (HELO mail-pl1-f194.google.com) (209.85.214.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 09:52:38 +0000 Received: by mail-pl1-f194.google.com with SMTP id ba4-v6so731523plb.11; Tue, 18 Sep 2018 02:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=i7grG/7RU08Nu0XZ2YBRtdlLVhz5O0Iu/D0kHYeujkE=; b=kp4N84NgBlHoTkI6q6cvNwIXmNm4LcE4iSadWl2zsWVwx63P7JOMLIrQcxZm6Sq1vH PJba5wU375fI5g/cpEN42sQKOLyUk616dfAoxd9EJ0eVSDF+B/kL34TtL4SKkdQRpHlb pmTaO+0RBuZCTEYo1UCQ4hA4uGIIwU7X7qbHrVNs+04aaxZEpzz6Tc9yfY5uUOYj2p8P 9/o/vTQKqBez5DHndEViQIAwyCCUYCUj8hj7FLV9MVl3CMd9RkwK3lRCP2KmpHXyMH/x krverwty1DfmuWyb+le7TLHXqBQnoWcgbeuFLTJ7w6YyxfleNsRObaei6aBR1dHe0zEu Sjnw== Return-Path: Received: from localhost (g106.218-225-177.ppp.wakwak.ne.jp. [218.225.177.106]) by smtp.gmail.com with ESMTPSA id e64-v6sm25000611pfk.87.2018.09.18.02.52.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Sep 2018 02:52:36 -0700 (PDT) Date: Tue, 18 Sep 2018 09:52:00 -0000 From: Stafford Horne To: Nick Clifton Cc: binutils@sourceware.org, GDB patches , Richard Henderson , Openrisc Subject: Re: [PATCH 0/4] OpenRISC binutils updates and new relocs Message-ID: <20180918095234.GP4594@lianli.shorne-pla.net> References: <20180821143823.16985-1-shorne@gmail.com> <20180908213515.GN4594@lianli.shorne-pla.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00622.txt.bz2 Content-length: 1833 On Mon, Sep 17, 2018 at 04:07:44PM +0100, Nick Clifton wrote: > Hi Stafford, > > > Does anyone have concerns with these patches? Mostly they are for openrisc > > parts only. > > Sorry for the long silence - I have been very busy of late. > > The patch series looks basically fine to me, so I have no concerns there. > There are a few minor formatting glitches, but nothing serious. Will you be able to point them out? Even just some hints? We have tried to follow conventions, but there might be some missed spots. I will go over everything again just in case and run any formatting tools I have, but any tips will be helpful. > I do not see any need to add extra document for the new relocs, unless you > have created new assembler pseudo-ops to generate them. (I did not see any > code to add such operators, but I may have missed something). As Richard mentioned we have added a few, see PATCH 3/4 in cpu/or1k.opc the change: (parse_reloc): Add new po(), gotpo() and gottppo() for LO13 relocations. Is this what you mean? I will look into adding the documentation for these. > I do have one question though. Is there a need to be able to distinguish > between binaries that use the new l.adrp instruction and those that don't. > For example if a library is built using the new instruction but then it is > linked into an executable which is supposed to run on silicon which does > not support the new instruction, should the linker issue an error ? If so, > how does it detect this situation ? As Richard mentioned we don't handle this. We have cases like this right now as well, i.e. binaries generated with `l.mul` or `l.div` instructions will link fine into an executable that assume those instrunctions should be emulated. That doesn't throw an error and I don't think it has been a problem. -Stafford