From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23025 invoked by alias); 24 Nov 2011 16:33:04 -0000 Received: (qmail 22932 invoked by uid 22791); 24 Nov 2011 16:32:57 -0000 X-SWARE-Spam-Status: No, hits=0.9 required=5.0 tests=AWL,BAYES_00,KAM_STOCKTIP,TW_BJ,TW_YM X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Nov 2011 16:32:38 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id EAEE8CB0394 for ; Thu, 24 Nov 2011 17:32:38 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c5dPsqDUy55F for ; Thu, 24 Nov 2011 17:32:29 +0100 (CET) Received: from [192.168.0.12] (mtg95-3-82-238-192-125.fbx.proxad.net [82.238.192.125]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id DF338CB03BF for ; Thu, 24 Nov 2011 17:24:21 +0100 (CET) From: Tristan Gingold Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: [commit/darwin] Port machoread to Darwin 11 (aka Lion) Date: Thu, 24 Nov 2011 16:33:00 -0000 Message-Id: To: "gdb-patches@sourceware.org ml" Mime-Version: 1.0 (Apple Message framework v1251.1) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00683.txt.bz2 Hi, to deal with OSO we were using the fact that symbols for an OSO in the exec= utable contained the section number for the OSO. But this reference was no= t in the spec and Lion has removed it. So to support Lion, machoread.c had to be partially rewritten. Hopefully, = it is now more robust. Reg-tested on both Darwin 10 and Darwin 11 but with the AdaCore test suite. There are still a few regressions that aren't yet fixed on Lion: the ones t= hat deal with attach/dettach. Still on my list. Tristan. gdb/ 2011-11-23 Tristan Gingold * machoread.c (oso_el): Remove num_Sections, symbols, offsets fields. Add oso_sym, end_sym and nbr_syms. (macho_register_oso): Change interface. (macho_symtab_add_minsym): New function. (macho_symtab_read): Rewritten. (get_archive_prefix_len): Remove trailing blanks. (oso_el_compare_name): Add comment. (struct macho_sym_hash_entry): New structure. (macho_relocate_common_syms): Remove. (macho_sym_hash_newfunc): New function. (macho_resolve_oso_sym_with_minsym): Likewise. (macho_add_oso_symfile): Rewritten. (macho_symfile_read_all_oso): Remove trailing blanks. Adjust code to free oso vector. (macho_symfile_read): Likewise. Move code to initialize minimal symbol diff --git a/gdb/machoread.c b/gdb/machoread.c index a454cd4..ffb1876 100644 --- a/gdb/machoread.c +++ b/gdb/machoread.c @@ -33,6 +33,7 @@ #include "aout/stab_gnu.h" #include "vec.h" #include "psympriv.h" +#include "complaints.h" =20 #include =20 @@ -48,21 +49,18 @@ static int mach_o_debug_level =3D 0; =20 typedef struct oso_el { - /* Object file name. */ + /* Object file name. Can also be a member name. */ const char *name; =20 /* Associated time stamp. */ unsigned long mtime; =20 - /* Number of sections. This is the length of SYMBOLS and OFFSETS array.= */ - int num_sections; + /* Stab symbols range for this OSO. */ + asymbol **oso_sym; + asymbol **end_sym; =20 - /* Each seaction of the object file is represented by a symbol and its - offset. If the offset is 0, we assume that the symbol is at offset 0 - in the OSO object file and a symbol lookup in the main file is - required to get the offset. */ - asymbol **symbols; - bfd_vma *offsets; + /* Number of interesting stabs in the range. */ + unsigned int nbr_syms; } oso_el; =20 @@ -86,181 +84,263 @@ macho_symfile_init (struct objfile *objfile) /* Add a new OSO to the vector of OSO to load. */ =20 static void -macho_register_oso (const asymbol *oso_sym, int nbr_sections, - asymbol **symbols, bfd_vma *offsets) +macho_register_oso (struct objfile *objfile, + asymbol **oso_sym, asymbol **end_sym, + unsigned int nbr_syms) { oso_el el; =20 - el.name =3D oso_sym->name; - el.mtime =3D oso_sym->value; - el.num_sections =3D nbr_sections; - el.symbols =3D symbols; - el.offsets =3D offsets; + el.name =3D (*oso_sym)->name; + el.mtime =3D (*oso_sym)->value; + el.oso_sym =3D oso_sym; + el.end_sym =3D end_sym; + el.nbr_syms =3D nbr_syms; VEC_safe_push (oso_el, oso_vector, &el); } =20 +/* Add symbol SYM to the minimal symbol table of OBJFILE. */ + +static void +macho_symtab_add_minsym (struct objfile *objfile, const asymbol *sym) +{ + if (sym->name =3D=3D NULL || *sym->name =3D=3D '\0') + { + /* Skip names that don't exist (shouldn't happen), or names + that are null strings (may happen). */ + return; + } + + if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK)) + { + CORE_ADDR symaddr; + CORE_ADDR offset; + enum minimal_symbol_type ms_type; + + offset =3D ANOFFSET (objfile->section_offsets, sym->section->index); + + /* Bfd symbols are section relative. */ + symaddr =3D sym->value + sym->section->vma; + + /* Select global/local/weak symbols. Note that bfd puts abs + symbols in their own section, so all symbols we are + interested in will have a section. */ + /* Relocate all non-absolute and non-TLS symbols by the + section offset. */ + if (sym->section !=3D &bfd_abs_section + && !(sym->section->flags & SEC_THREAD_LOCAL)) + symaddr +=3D offset; + + if (sym->section =3D=3D &bfd_abs_section) + ms_type =3D mst_abs; + else if (sym->section->flags & SEC_CODE) + { + if (sym->flags & (BSF_GLOBAL | BSF_WEAK)) + ms_type =3D mst_text; + else + ms_type =3D mst_file_text; + } + else if (sym->section->flags & SEC_ALLOC) + { + if (sym->flags & (BSF_GLOBAL | BSF_WEAK)) + { + if (sym->section->flags & SEC_LOAD) + ms_type =3D mst_data; + else + ms_type =3D mst_bss; + } + else if (sym->flags & BSF_LOCAL) + { + /* Not a special stabs-in-elf symbol, do regular + symbol processing. */ + if (sym->section->flags & SEC_LOAD) + ms_type =3D mst_file_data; + else + ms_type =3D mst_file_bss; + } + else + ms_type =3D mst_unknown; + } + else + return; /* Skip this symbol. */ + + prim_record_minimal_symbol_and_info + (sym->name, symaddr, ms_type, sym->section->index, + sym->section, objfile); + } +} + /* Build the minimal symbol table from SYMBOL_TABLE of length - NUMBER_OF_SYMBOLS for OBJFILE. - Read OSO files at the end. */ + NUMBER_OF_SYMBOLS for OBJFILE. Registers OSO filenames found. */ =20 static void macho_symtab_read (struct objfile *objfile, long number_of_symbols, asymbol **symbol_table) { - struct gdbarch *gdbarch =3D get_objfile_arch (objfile); - long storage_needed; - long i, j; - CORE_ADDR offset; - enum minimal_symbol_type ms_type; - unsigned int nbr_sections =3D bfd_count_sections (objfile->obfd); - asymbol **first_symbol =3D NULL; - bfd_vma *first_offset =3D NULL; - const asymbol *oso_file =3D NULL; + long i; + const asymbol *dir_so =3D NULL; + const asymbol *file_so =3D NULL; + asymbol **oso_file =3D NULL; + unsigned int nbr_syms; =20 - for (i =3D 0; i < number_of_symbols; i++) - { - asymbol *sym =3D symbol_table[i]; - bfd_mach_o_asymbol *mach_o_sym =3D (bfd_mach_o_asymbol *)sym; + /* Current state while reading stabs. */ + enum + { + /* Not within an SO part. Only non-debugging symbols should be presen= t, + and will be added to the minimal symbols table. */ + S_NO_SO, =20 - offset =3D ANOFFSET (objfile->section_offsets, sym->section->index); + /* First SO read. Introduce an SO section, and may be followed by a s= econd + SO. The SO section should contain onl debugging symbols. */ + S_FIRST_SO, =20 - if (sym->flags & BSF_DEBUGGING) - { - bfd_vma addr; + /* Second non-null SO found, just after the first one. Means that the= first + is in fact a directory name. */ + S_SECOND_SO, =20 - /* Debugging symbols are used to collect OSO file names as well - as section offsets. */ + /* Non-null OSO found. Debugging info are DWARF in this OSO file. */ + S_DWARF_FILE, =20 - switch (mach_o_sym->n_type) - { - case N_SO: - /* An empty SO entry terminates a chunk for an OSO file. */ - if ((sym->name =3D=3D NULL || sym->name[0] =3D=3D 0) && oso_file != =3D NULL) - { - macho_register_oso (oso_file, nbr_sections, - first_symbol, first_offset); - first_symbol =3D NULL; - first_offset =3D NULL; - oso_file =3D NULL; - } - break; - case N_FUN: - case N_STSYM: - if (sym->name =3D=3D NULL || sym->name[0] =3D=3D '\0') - break; - /* Fall through. */ - case N_BNSYM: - gdb_assert (oso_file !=3D NULL); - addr =3D sym->value=20 - + bfd_get_section_vma (sym->section->bfd, sym->section); - if (addr !=3D 0 - && first_symbol[sym->section->index] =3D=3D NULL) - { - /* These STAB entries can directly relocate a section. = */ - first_symbol[sym->section->index] =3D sym; - first_offset[sym->section->index] =3D addr + offset; - } - break; - case N_GSYM: - gdb_assert (oso_file !=3D NULL); - if (first_symbol[sym->section->index] =3D=3D NULL) - { - /* This STAB entry needs a symbol look-up to relocate - the section. */ - first_symbol[sym->section->index] =3D sym; - first_offset[sym->section->index] =3D 0; - } - break; - case N_OSO: - /* New OSO file. */ - gdb_assert (oso_file =3D=3D NULL); - first_symbol =3D (asymbol **)xmalloc (nbr_sections - * sizeof (asymbol *)); - first_offset =3D (bfd_vma *)xmalloc (nbr_sections - * sizeof (bfd_vma)); - for (j =3D 0; j < nbr_sections; j++) - first_symbol[j] =3D NULL; - oso_file =3D sym; - break; - } - continue; - } + S_STAB_FILE + } state =3D S_NO_SO; =20 - if (sym->name =3D=3D NULL || *sym->name =3D=3D '\0') - { - /* Skip names that don't exist (shouldn't happen), or names - that are null strings (may happen). */ - continue; - } + for (i =3D 0; i < number_of_symbols; i++) + { + const asymbol *sym =3D symbol_table[i]; + bfd_mach_o_asymbol *mach_o_sym =3D (bfd_mach_o_asymbol *)sym; =20 - if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK)) - { - struct minimal_symbol *msym; - CORE_ADDR symaddr; - - /* Bfd symbols are section relative. */ - symaddr =3D sym->value + sym->section->vma; - - /* Select global/local/weak symbols. Note that bfd puts abs - symbols in their own section, so all symbols we are - interested in will have a section. */ - /* Relocate all non-absolute and non-TLS symbols by the - section offset. */ - if (sym->section !=3D &bfd_abs_section - && !(sym->section->flags & SEC_THREAD_LOCAL)) - symaddr +=3D offset; - - if (sym->section =3D=3D &bfd_abs_section) - ms_type =3D mst_abs; - else if (sym->section->flags & SEC_CODE) - { - if (sym->flags & (BSF_GLOBAL | BSF_WEAK)) - ms_type =3D mst_text; - else - ms_type =3D mst_file_text; - } - else if (sym->section->flags & SEC_ALLOC) - { - if (sym->flags & (BSF_GLOBAL | BSF_WEAK)) - { - if (sym->section->flags & SEC_LOAD) - ms_type =3D mst_data; - else - ms_type =3D mst_bss; - } - else if (sym->flags & BSF_LOCAL) - { - /* Not a special stabs-in-elf symbol, do regular - symbol processing. */ - if (sym->section->flags & SEC_LOAD) - ms_type =3D mst_file_data; - else - ms_type =3D mst_file_bss; - } - else - ms_type =3D mst_unknown; - } - else - continue; /* Skip this symbol. */ + switch (state) + { + case S_NO_SO: + if (mach_o_sym->n_type =3D=3D N_SO) + { + /* Start of object stab. */ + if (sym->name =3D=3D NULL || sym->name[0] =3D=3D 0) + { + /* Unexpected empty N_SO. */ + complaint (&symfile_complaints, + _("Unexpected empty N_SO stab")); + } + else + { + file_so =3D sym; + dir_so =3D NULL; + state =3D S_FIRST_SO; + } + } + else if (sym->flags & BSF_DEBUGGING) + { + /* Debugging symbols are not expected here. */ + complaint (&symfile_complaints, + _("Unexpected debug stab outside SO markers")); + } + else + { + /* Non-debugging symbols go to the minimal symbol table. */ + macho_symtab_add_minsym (objfile, sym); + } + break; =20 - gdb_assert (sym->section->index < nbr_sections); - if (oso_file !=3D NULL - && first_symbol[sym->section->index] =3D=3D NULL) - { - /* Standard symbols can directly relocate sections. */ - first_symbol[sym->section->index] =3D sym; - first_offset[sym->section->index] =3D symaddr; - } + case S_FIRST_SO: + case S_SECOND_SO: + if (mach_o_sym->n_type =3D=3D N_SO) + { + if (sym->name =3D=3D NULL || sym->name[0] =3D=3D 0) + { + /* Unexpected empty N_SO. */ + complaint (&symfile_complaints, _("Empty SO section")); + state =3D S_NO_SO; + } + else if (state =3D=3D S_FIRST_SO) + { + /* Second SO stab for the file name. */ + dir_so =3D file_so; + file_so =3D sym; + state =3D S_SECOND_SO; + } + else + complaint (&symfile_complaints, _("Three SO in a raw")); + } + else if (mach_o_sym->n_type =3D=3D N_OSO) + { + if (sym->name =3D=3D NULL || sym->name[0] =3D=3D 0) + { + /* Empty OSO. Means that this file was compiled with + stabs. */ + state =3D S_STAB_FILE; + warning (_("stabs debugging not supported for %s"), + file_so->name); + } + else + { + /* Non-empty OSO for a Dwarf file. */ + oso_file =3D symbol_table + i; + nbr_syms =3D 0; + state =3D S_DWARF_FILE; + } + } + else + complaint (&symfile_complaints, + _("Unexpected stab after SO")); + break; =20 - msym =3D prim_record_minimal_symbol_and_info - (sym->name, symaddr, ms_type, sym->section->index, - sym->section, objfile); - } + case S_STAB_FILE: + case S_DWARF_FILE: + if (mach_o_sym->n_type =3D=3D N_SO) + { + if (sym->name =3D=3D NULL || sym->name[0] =3D=3D 0) + { + /* End of file. */ + if (state =3D=3D S_DWARF_FILE) + macho_register_oso (objfile, oso_file, symbol_table + = i, + nbr_syms); + state =3D S_NO_SO; + } + else + { + complaint (&symfile_complaints, _("Missing nul SO")); + file_so =3D sym; + dir_so =3D NULL; + state =3D S_FIRST_SO; + } + } + else if (sym->flags & BSF_DEBUGGING) + { + if (state =3D=3D S_STAB_FILE) + { + /* FIXME: to be implemented. */ + } + else + { + switch (mach_o_sym->n_type) + { + case N_FUN: + if (sym->name =3D=3D NULL || sym->name[0] =3D=3D 0) + break; + /* Fall through. */ + case N_STSYM: + /* Interesting symbol. */ + nbr_syms++; + break; + case N_ENSYM: + case N_BNSYM: + case N_GSYM: + break; + default: + complaint (&symfile_complaints, + _("unhandled stab for dwarf OSO file")); + break; + } + } + } + else + complaint (&symfile_complaints, + _("non-debugging symbol within SO")); + break; + } } =20 - /* Just in case there is no trailing SO entry. */ - if (oso_file !=3D NULL) - macho_register_oso (oso_file, nbr_sections, first_symbol, first_offset= ); + if (state !=3D S_NO_SO) + complaint (&symfile_complaints, _("missing nul SO")); } =20 /* If NAME describes an archive member (ie: ARCHIVE '(' MEMBER ')'), @@ -275,13 +355,16 @@ get_archive_prefix_len (const char *name) =20 if (name_len =3D=3D 0 || name[name_len - 1] !=3D ')') return -1; -=20=20 + lparen =3D strrchr (name, '('); if (lparen =3D=3D NULL || lparen =3D=3D name) return -1; return lparen - name; } =20 +/* Compare function to qsort OSOs, so that members of a library are + gathered. */ + static int oso_el_compare_name (const void *vl, const void *vr) { @@ -291,77 +374,86 @@ oso_el_compare_name (const void *vl, const void *vr) return strcmp (l->name, r->name); } =20 -/* Relocate all of ABFD's common symbols immediately. +/* Hash table entry structure for the stabs symbols in the main object fil= e. + This is used to speed up lookup for symbols in the OSO. */ =20 - This modifies the section and address of all common symbols to become - absolute symbols with their address set to match the address given by - the main objfile's symbol table. - - The reason why the common symbols have to be handled separately - is because relocation is performed relative to section start. - But there is no section in this case. So the "relocation" of - these common symbols is performed by finding their address in - the main objfile's symbol table, where we know it's been relocated. +struct macho_sym_hash_entry +{ + struct bfd_hash_entry base; + const asymbol *sym; +}; =20 - ABFD is an OSO's bfd. - MAIN_OBJFILE is the object file from which the OSO is a part. */ +/* Routine to create an entry in the hash table. */ =20 -static void -macho_relocate_common_syms(bfd *abfd, struct objfile *main_objfile) +static struct bfd_hash_entry * +macho_sym_hash_newfunc (struct bfd_hash_entry *entry, + struct bfd_hash_table *table, + const char *string) { - int storage; - int i; - char leading_char; - asymbol **symbol_table; - - storage =3D bfd_get_symtab_upper_bound (abfd); - symbol_table =3D (asymbol **) xmalloc (storage); - bfd_canonicalize_symtab (abfd, symbol_table); + struct macho_sym_hash_entry *ret =3D (struct macho_sym_hash_entry *) ent= ry; + + /* Allocate the structure if it has not already been allocated by a + subclass. */ + if (ret =3D=3D NULL) + ret =3D (struct macho_sym_hash_entry *) bfd_hash_allocate (table, + sizeof (* ret= )); + if (ret =3D=3D NULL) + return NULL; =20 - leading_char =3D bfd_get_symbol_leading_char (abfd); + /* Call the allocation method of the superclass. */ + ret =3D (struct macho_sym_hash_entry *) + bfd_hash_newfunc ((struct bfd_hash_entry *) ret, table, string); =20 - for (i =3D 0; symbol_table[i]; i++) + if (ret) { - asymbol *sym =3D symbol_table[i]; + /* Initialize the local fields. */ + ret->sym =3D NULL; + } =20 - if (bfd_is_com_section (sym->section)) - { - /* This one must be solved. */ - struct minimal_symbol *msym; - const char *name =3D sym->name; + return (struct bfd_hash_entry *) ret; +} =20 - if (name[0] =3D=3D leading_char) - name++; +/* Get the value of SYM from the minimal symtab of MAIN_OBJFILE. This is = used + to get the value of global and common symbols. */ =20 - msym =3D lookup_minimal_symbol (name, NULL, main_objfile); - if (msym =3D=3D NULL) - { - warning (_("can't find symbol '%s' in minsymtab"), name); - continue; - } - else - { - sym->section =3D &bfd_abs_section; - sym->value =3D SYMBOL_VALUE_ADDRESS (msym); - } - } +static CORE_ADDR +macho_resolve_oso_sym_with_minsym (struct objfile *main_objfile, asymbol *= sym) +{ + /* For common symbol and global symbols, use the min symtab. */ + struct minimal_symbol *msym; + const char *name =3D sym->name; + + if (name[0] =3D=3D bfd_get_symbol_leading_char (main_objfile->obfd)) + ++name; + msym =3D lookup_minimal_symbol (name, NULL, main_objfile); + if (msym =3D=3D NULL) + { + warning (_("can't find symbol '%s' in minsymtab"), name); + return 0; } - - xfree (symbol_table); + else + return SYMBOL_VALUE_ADDRESS (msym); } =20 -/* Add an oso file as a symbol file. */ +/* Add oso file OSO/ABFD as a symbol file. */ =20 static void macho_add_oso_symfile (oso_el *oso, bfd *abfd, struct objfile *main_objfile, int symfile_flags) { - struct objfile *objfile; + int storage; int i; - char leading_char; + asymbol **symbol_table; + asymbol **symp; + struct bfd_hash_table table; + int nbr_sections; + + /* Per section flag to mark which section have been rebased. */ + unsigned char *sections_rebased; =20 if (mach_o_debug_level > 0) - printf_unfiltered (_("Loading symbols from oso: %s\n"), oso->name); + printf_unfiltered + (_("Loading debugging symbols from oso: %s\n"), oso->name); =20 if (!bfd_check_format (abfd, bfd_object)) { @@ -371,65 +463,164 @@ macho_add_oso_symfile (oso_el *oso, bfd *abfd, return; } =20 + if (abfd->my_archive =3D=3D NULL && oso->mtime !=3D bfd_get_mtime (abfd)) + { + warning (_("`%s': file time stamp mismatch."), oso->name); + bfd_close (abfd); + return; + } + + if (!bfd_hash_table_init_n (&table, macho_sym_hash_newfunc, + sizeof (struct macho_sym_hash_entry), + oso->nbr_syms)) + { + warning (_("`%s': can't create hash table"), oso->name); + bfd_close (abfd); + return; + } + bfd_set_cacheable (abfd, 1); =20 - /* Relocate sections. */ + /* Read symbols table. */ + storage =3D bfd_get_symtab_upper_bound (abfd); + symbol_table =3D (asymbol **) xmalloc (storage); + bfd_canonicalize_symtab (abfd, symbol_table); =20 - leading_char =3D bfd_get_symbol_leading_char (main_objfile->obfd); + /* Init section flags. */ + nbr_sections =3D bfd_count_sections (abfd); + sections_rebased =3D (unsigned char *) alloca (nbr_sections); + for (i =3D 0; i < nbr_sections; i++) + sections_rebased[i] =3D 0; =20 - for (i =3D 0; i < oso->num_sections; i++) + /* Put symbols for the OSO file in the hash table. */ + for (symp =3D oso->oso_sym; symp !=3D oso->end_sym; symp++) { - asection *sect; - const char *sectname; - bfd_vma vma; - - /* Empty slot. */ - if (oso->symbols[i] =3D=3D NULL) - continue; + const asymbol *sym =3D *symp; + bfd_mach_o_asymbol *mach_o_sym =3D (bfd_mach_o_asymbol *)sym; =20 - if (oso->offsets[i]) - vma =3D oso->offsets[i]; - else + switch (mach_o_sym->n_type) + { + case N_ENSYM: + case N_BNSYM: + case N_GSYM: + sym =3D NULL; + break; + case N_FUN: + if (sym->name =3D=3D NULL || sym->name[0] =3D=3D 0) + sym =3D NULL; + break; + case N_STSYM: + break; + default: + sym =3D NULL; + break; + } + if (sym !=3D NULL) { - struct minimal_symbol *msym; - const char *name =3D oso->symbols[i]->name; - - if (name[0] =3D=3D leading_char) - ++name; - - if (mach_o_debug_level > 3) - printf_unfiltered (_("resolve sect %s with %s\n"), - oso->symbols[i]->section->name, - oso->symbols[i]->name); - msym =3D lookup_minimal_symbol (name, NULL, main_objfile); - if (msym =3D=3D NULL) + struct macho_sym_hash_entry *ent; + + ent =3D (struct macho_sym_hash_entry *) + bfd_hash_lookup (&table, sym->name, TRUE, FALSE); + if (ent->sym !=3D NULL) + complaint (&symfile_complaints, + _("Duplicated symbol %s in symbol table"), sym->nam= e); + else { - warning (_("can't find symbol '%s' in minsymtab"), name); - continue; + if (mach_o_debug_level > 4) + { + struct gdbarch *arch =3D get_objfile_arch (main_objfile); + printf_unfiltered + (_("Adding symbol %s (addr: %s)\n"), + sym->name, paddress (arch, sym->value)); + } + ent->sym =3D sym; } - else - vma =3D SYMBOL_VALUE_ADDRESS (msym); } - sectname =3D (char *)oso->symbols[i]->section->name; + } =20 - sect =3D bfd_get_section_by_name (abfd, sectname); - if (sect =3D=3D NULL) + /* Relocate symbols of the OSO. */ + for (i =3D 0; symbol_table[i]; i++) + { + asymbol *sym =3D symbol_table[i]; + bfd_mach_o_asymbol *mach_o_sym =3D (bfd_mach_o_asymbol *)sym; + + if (mach_o_sym->n_type & BFD_MACH_O_N_STAB) + continue; + if ((mach_o_sym->n_type & BFD_MACH_O_N_TYPE) =3D=3D BFD_MACH_O_N_UNDF + && sym->value !=3D 0) { - warning (_("can't find section '%s' in OSO file %s"), - sectname, oso->name); - continue; + /* For common symbol use the min symtab and modify the OSO + symbol table. */ + CORE_ADDR res; + + res =3D macho_resolve_oso_sym_with_minsym (main_objfile, sym); + if (res !=3D 0) + { + sym->section =3D &bfd_com_section; + sym->value =3D res; + } } - bfd_set_section_vma (abfd, sect, vma); + else if ((mach_o_sym->n_type & BFD_MACH_O_N_TYPE) =3D=3D BFD_MACH_O_= N_SECT) + { + /* Normal symbol. */ + asection *sec =3D sym->section; + bfd_mach_o_section *msec; + unsigned int sec_type; + + /* Skip buggy ones. */ + if (sec =3D=3D NULL || sections_rebased[sec->index] !=3D 0) + continue; + + /* Only consider regular, non-debugging sections. */ + msec =3D bfd_mach_o_get_mach_o_section (sec); + sec_type =3D msec->flags & BFD_MACH_O_SECTION_TYPE_MASK; + if ((sec_type =3D=3D BFD_MACH_O_S_REGULAR + || sec_type =3D=3D BFD_MACH_O_S_ZEROFILL) + && (msec->flags & BFD_MACH_O_S_ATTR_DEBUG) =3D=3D 0) + { + CORE_ADDR addr =3D 0; + + if ((mach_o_sym->n_type & BFD_MACH_O_N_EXT) !=3D 0) + { + /* Use the min symtab for global symbols. */ + addr =3D macho_resolve_oso_sym_with_minsym (main_objfile= , sym); + } + else + { + struct macho_sym_hash_entry *ent; + + ent =3D (struct macho_sym_hash_entry *) + bfd_hash_lookup (&table, sym->name, FALSE, FALSE); + if (ent !=3D NULL) + addr =3D bfd_asymbol_value (ent->sym); + } + + /* Adjust the section. */ + if (addr !=3D 0) + { + CORE_ADDR res =3D addr - sym->value; =20 - if (mach_o_debug_level > 1) - printf_unfiltered (_(" %s: %s\n"), - core_addr_to_string (vma), sectname); + if (mach_o_debug_level > 3) + { + struct gdbarch *arch =3D get_objfile_arch (main_objf= ile); + printf_unfiltered + (_("resolve sect %s with %s (set to %s)\n"), + sec->name, sym->name, + paddress (arch, res)); + } + bfd_set_section_vma (abfd, sec, res); + sections_rebased[sec->index] =3D 1; + } + } + else + { + /* Mark the section as never rebased. */ + sections_rebased[sec->index] =3D 2; + } + } } =20 - /* Deal with the common symbols now, as they need special handing. - Doing it now sets them up so that we don't accidently try to - relocate them during the normal relocation phase. */ - macho_relocate_common_syms (abfd, main_objfile); + bfd_hash_table_free (&table); =20 /* Make sure that the filename was malloc'ed. The current filename comes either from an OSO symbol name or from an archive name. Memory for b= oth @@ -438,7 +629,7 @@ macho_add_oso_symfile (oso_el *oso, bfd *abfd, =20 /* We need to clear SYMFILE_MAINLINE to avoid interractive question from symfile.c:symbol_file_add_with_addrs_or_offsets. */ - objfile =3D symbol_file_add_from_bfd + symbol_file_add_from_bfd (abfd, symfile_flags & ~(SYMFILE_MAINLINE | SYMFILE_VERBOSE), NULL, main_objfile->flags & (OBJF_REORDERED | OBJF_SHARED | OBJF_READNOW | OBJF_USERLOADED), @@ -456,7 +647,7 @@ macho_symfile_read_all_oso (struct objfile *main_objfil= e, int symfile_flags) =20 vec =3D oso_vector; oso_vector =3D NULL; -=20=20 + /* Sort oso by name so that files from libraries are gathered. */ qsort (VEC_address (oso_el, vec), VEC_length (oso_el, vec), sizeof (oso_el), oso_el_compare_name); @@ -464,7 +655,7 @@ macho_symfile_read_all_oso (struct objfile *main_objfil= e, int symfile_flags) for (ix =3D 0; VEC_iterate (oso_el, vec, ix, oso);) { int pfx_len; -=20=20=20=20=20=20 + /* Check if this is a library name. */ pfx_len =3D get_archive_prefix_len (oso->name); if (pfx_len > 0) @@ -486,7 +677,7 @@ macho_symfile_read_all_oso (struct objfile *main_objfil= e, int symfile_flags) if (strncmp (oso2->name, archive_name, pfx_len) !=3D 0) break; } -=09=20=20 + /* Open the archive and check the format. */ archive_bfd =3D bfd_openr (archive_name, gnutarget); if (archive_bfd =3D=3D NULL) @@ -505,7 +696,7 @@ macho_symfile_read_all_oso (struct objfile *main_objfil= e, int symfile_flags) continue; } member_bfd =3D bfd_openr_next_archived_file (archive_bfd, NULL); -=09=20=20 + if (member_bfd =3D=3D NULL) { warning (_("Could not read archive members out of " @@ -572,11 +763,6 @@ macho_symfile_read_all_oso (struct objfile *main_objfi= le, int symfile_flags) } } =20 - for (ix =3D 0; VEC_iterate (oso_el, vec, ix, oso); ix++) - { - xfree (oso->symbols); - xfree (oso->offsets); - } VEC_free (oso_el, vec); } =20 @@ -655,14 +841,10 @@ static void macho_symfile_read (struct objfile *objfile, int symfile_flags) { bfd *abfd =3D objfile->obfd; - struct cleanup *back_to; CORE_ADDR offset; long storage_needed; bfd *dsym_bfd; =20 - init_minimal_symbol_collection (); - back_to =3D make_cleanup_discard_minimal_symbols (); - /* Get symbols from the symbol table only if the file is an executable. The symbol table of object files is not relocated and is expected to be in the executable. */ @@ -679,27 +861,33 @@ macho_symfile_read (struct objfile *objfile, int symf= ile_flags) { asymbol **symbol_table; long symcount; + struct cleanup *back_to; =20 symbol_table =3D (asymbol **) xmalloc (storage_needed); make_cleanup (xfree, symbol_table); + + init_minimal_symbol_collection (); + back_to =3D make_cleanup_discard_minimal_symbols (); + symcount =3D bfd_canonicalize_symtab (objfile->obfd, symbol_table); -=09=20=20 + if (symcount < 0) error (_("Can't read symbols from %s: %s"), bfd_get_filename (objfile->obfd), bfd_errmsg (bfd_get_error ())); -=09=20=20 + macho_symtab_read (objfile, symcount, symbol_table); + + install_minimal_symbols (objfile); + do_cleanups (back_to); } -=20=20=20=20=20=20 - install_minimal_symbols (objfile); =20 /* Try to read .eh_frame / .debug_frame. */ /* First, locate these sections. We ignore the result status as it only checks for debug info. */ dwarf2_has_info (objfile, NULL); dwarf2_build_frame_info (objfile); -=20=20=20=20=20=20 + /* Check for DSYM file. */ dsym_bfd =3D macho_check_dsym (objfile); if (dsym_bfd !=3D NULL) @@ -712,11 +900,6 @@ macho_symfile_read (struct objfile *objfile, int symfi= le_flags) printf_unfiltered (_("dsym file found\n")); =20 /* Remove oso. They won't be used. */ - for (ix =3D 0; VEC_iterate (oso_el, oso_vector, ix, oso); ix++) - { - xfree (oso->symbols); - xfree (oso->offsets); - } VEC_free (oso_el, oso_vector); oso_vector =3D NULL; =20 @@ -733,7 +916,7 @@ macho_symfile_read (struct objfile *objfile, int symfil= e_flags) =20 /* Add the dsym file as a separate file. */ symbol_file_add_separate (dsym_bfd, symfile_flags, objfile); -=20=20=20=20=20=20 + /* Don't try to read dwarf2 from main file or shared libraries. */ return; } @@ -821,7 +1004,7 @@ macho_symfile_offsets (struct objfile *objfile, { const char *bfd_sect_name =3D osect->the_bfd_section->name; int sect_index =3D osect->the_bfd_section->index; -=20=20=20=20=20=20 + if (strncmp (bfd_sect_name, "LC_SEGMENT.", 11) =3D=3D 0) bfd_sect_name +=3D 11; if (strcmp (bfd_sect_name, "__TEXT") =3D=3D 0