From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68633 invoked by alias); 9 Aug 2019 13:22:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68624 invoked by uid 89); 9 Aug 2019 13:22:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR04-VI1-obe.outbound.protection.outlook.com Received: from mail-eopbgr80050.outbound.protection.outlook.com (HELO EUR04-VI1-obe.outbound.protection.outlook.com) (40.107.8.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Aug 2019 13:22:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2iusAHB0Fc4Qk3gM+MjmKn49POBYYz4CD2DMYeM919k=; b=1jYQlRS38Ft52zWyOr0ADwGQhdzl8TGS6BOI62OD3AhDy02MdlHXyIYgLow/IvCIsvmWdEBJNINCALz3iBYpKRd0wadWR2VQ9Tw2JIWBanFTlP5F/ksk1cMvDo+TvY+umoLmvOpwfC2Hb5SKANVRffaN5CFkfpqvyV0I2ZxM8lg= Received: from DB6PR0802CA0045.eurprd08.prod.outlook.com (2603:10a6:4:a3::31) by AM6PR08MB4952.eurprd08.prod.outlook.com (2603:10a6:20b:e1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.20; Fri, 9 Aug 2019 13:22:12 +0000 Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::207) by DB6PR0802CA0045.outlook.office365.com (2603:10a6:4:a3::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2157.16 via Frontend Transport; Fri, 9 Aug 2019 13:22:12 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT015.mail.protection.outlook.com (10.152.16.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Fri, 9 Aug 2019 13:22:10 +0000 Received: ("Tessian outbound cc8a947d4660:v26"); Fri, 09 Aug 2019 13:22:06 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 36aae6b61054462e X-CR-MTA-TID: 64aa7808 Received: from 5d8416b5985b.1 (cr-mta-lb-1.cr-mta-net [104.47.12.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id CB55D13C-A3FB-4408-8006-101AED0C6F0C.1; Fri, 09 Aug 2019 13:22:01 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5d8416b5985b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Aug 2019 13:22:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QFjCKZkge+XQ6YnvwZ8VKr6gWwkKE0eOmTRdwxRnzON0EZoXRVy35WaFeUrDR9rL5ZD4HQAr3V1hmofw/+E35faFfrD+PxlsZ4axAyiTDnEvj5ymd4okeLCWFp4rXQQc1UnDDx8/g6RxQlcqKDRKfIpwVk4L9Fj/a0XUjS8LqXyGJoosFPMNo4Q5/byBz+7DYEZ9RFV2qmauZIcwB66s+CXk4g+jSzAu6dhS+fyb4pameMXLSFiQpA6+hrwYM5iBB4iconjsNFBDibZe4BFpYjn1P9hxSxpuJD7DLi0sRaQf3xvwJrMj81xlzn43u0ZWXIHuG87gMxbxnXk1Ejf3og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2iusAHB0Fc4Qk3gM+MjmKn49POBYYz4CD2DMYeM919k=; b=hiC21lu6y593UtQnJ2f5pR5mcsLh6p+2XuQNFXLd6baGLBTJFe1KHuMjUhmPDzrNdyg/Ua2LPLq8AvpMPAUdYDYa/itSQweHKKYVMKwiUMarlnj2w45vrfsBmuBNq0z4vmEkKP5QXDWuJxJVH5UOf0rlbAR+Rxx0q8tZyU10sbk4/2skjHGjdLgQNNKx53yBcFv4Qxe7qU06c2dLCPXujMFG11WpjAuA4fbGnz5QuqeFSfMiZhzyr8lBVoWZg9MDI+Itr++NWVT2Fzoylh1E5Di1QFzD5Ykw42P5hwHXJtQvbBd4LerGsPenxlIbmGQR0oxWj1VnwSlyPwJIXrUPxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2iusAHB0Fc4Qk3gM+MjmKn49POBYYz4CD2DMYeM919k=; b=1jYQlRS38Ft52zWyOr0ADwGQhdzl8TGS6BOI62OD3AhDy02MdlHXyIYgLow/IvCIsvmWdEBJNINCALz3iBYpKRd0wadWR2VQ9Tw2JIWBanFTlP5F/ksk1cMvDo+TvY+umoLmvOpwfC2Hb5SKANVRffaN5CFkfpqvyV0I2ZxM8lg= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2565.eurprd08.prod.outlook.com (10.172.251.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.20; Fri, 9 Aug 2019 13:22:00 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::5ce5:cf42:42dd:eda1]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::5ce5:cf42:42dd:eda1%6]) with mapi id 15.20.2157.020; Fri, 9 Aug 2019 13:22:00 +0000 From: Alan Hayward To: Pedro Alves , Tom Tromey CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH V2] AArch64 pauth: Indicate unmasked addresses in backtrace Date: Fri, 09 Aug 2019 13:22:00 -0000 Message-ID: References: <20190730144123.11135-1-alan.hayward@arm.com> <728af5fa-8e3d-845c-d72f-60b1d2067643@redhat.com> <474e8e87-50d4-874f-787f-ef5f5fbb6cc3@redhat.com> In-Reply-To: <474e8e87-50d4-874f-787f-ef5f5fbb6cc3@redhat.com> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2565; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:7219; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(136003)(346002)(376002)(396003)(366004)(39860400002)(51444003)(199004)(189003)(33656002)(476003)(486006)(66946007)(66476007)(66556008)(11346002)(64756008)(66446008)(71190400001)(71200400001)(446003)(76116006)(91956017)(256004)(8936002)(50226002)(2616005)(2906002)(102836004)(25786009)(6436002)(14454004)(6486002)(4326008)(8676002)(81166006)(57306001)(305945005)(26005)(7736002)(6512007)(81156014)(54906003)(316002)(110136005)(5660300002)(36756003)(76176011)(3846002)(53936002)(6246003)(6116002)(229853002)(478600001)(99286004)(6506007)(53546011)(186003)(86362001)(66066001)(403724002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2565;H:DB6PR0802MB2133.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: U4t/LwmtZyNFNAv4wLKSWJ9I3C2vzDGSAQWKQa04SmpUg0nN4j8ZmHug9X/XprXMADsVPE9o3u3W6/1/p6kb0Dy1iGIeqb7oFaxnV+U7wh6VItwMFZGQB2PMKHJ47MniMh6vuUs5PJOFu2Dx32Df3Souki/D+IssJiGuS6L0FE6SrPrnGSSmV0HHAA1RZ2yirHSDkwTg5zegcmsoC+vpe5An8zH/EN17AuKh0w2GVmbFmBsQwbFu1IlUOrj7vENkD2lq3SQi+IQXkPClzAkNjADKLEaXHRsLL/ukWLyyxbn+Pjt72H+RdDPacB7GV1JRwfQoeJw8IpqbeIbyrRlFsBUcrZT/NQm/NZ83zLcSus6nuGzZpd/NLEM15Yh3Mf7TMWvwOWes+xYj3P1UpaA7y7lWLqlp8z22Ywf0/E/gTzE= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <8D65F7DDFA0D2B469A9F2163E8882A60@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 58079183-506b-4e7f-cacd-08d71ccc8f93 X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00221.txt.bz2 DQoNCj4gT24gOCBBdWcgMjAxOSwgYXQgMTE6MzMsIFBlZHJvIEFsdmVzIDxw YWx2ZXNAcmVkaGF0LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiA4LzgvMTkgOTo1 NSBBTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPiANCj4+IGRpZmYgLS1naXQg YS9nZGIvc3RhY2suYyBiL2dkYi9zdGFjay5jDQo+PiBpbmRleCAwODU5ODE1 YmFmLi5jNTk5Y2FmNTFjIDEwMDY0NA0KPj4gLS0tIGEvZ2RiL3N0YWNrLmMN Cj4+ICsrKyBiL2dkYi9zdGFjay5jDQo+PiBAQCAtMTMwMSw3ICsxMzAxLDcg QEAgcHJpbnRfZnJhbWUgKGNvbnN0IGZyYW1lX3ByaW50X29wdGlvbnMgJmZw X29wdHMsDQo+PiAgICAgICAgICAgIHsNCj4+ICAgICAgICAgICAgICB1aW91 dC0+ZmllbGRfY29yZV9hZGRyICgiYWRkciIsIGdkYmFyY2gsIHBjKTsNCj4+ ICAgICAgICAgICAgICBpZiAoZ2V0X2ZyYW1lX3BjX21hc2tlZCAoZnJhbWUp KQ0KPj4gLSAgICAgICAgICAgICAgIHVpb3V0LT5maWVsZF9zdHJpbmcgKCJw YWMiLCAiIFtQQUNdIik7DQo+PiArICAgICAgICAgICAgICAgdWlvdXQtPmZp ZWxkX3N0cmluZyAoImFkZHIiLCAiIFtQQUNdIik7DQo+PiAgICAgICAgICAg IH0NCj4+ICAgICAgICAgIGVsc2UNCj4+ICAgICAgICAgICAgdWlvdXQtPmZp ZWxkX3N0cmluZyAoImFkZHIiLCAiPHVuYXZhaWxhYmxlPiIsDQo+PiANCj4g DQo+IC4uLiBiZWNhdXNlIEkgdGhpbmsgdGhhdCB0aGlzIHJlc3VsdHMgaW4g TUkgcHJpbnRpbmcgdHdvIGRpZmZlcmVudCAiYWRkciIgYXR0cmlidXRlcy4N Cj4gDQo+IEluc3RlYWQsIHlvdSdsbCBuZWVkIHRvIGJ1aWxkIGEgc3RyaW5n LCB3aXRoIGUuZy4sIHN0cmluZ19wcmludGYsDQo+IGFuZCB1c2UgdWlvdXQt PmZpZWxkX3N0cmluZyB3aXRoIHVpX291dF9zdHlsZV9raW5kOjpBRERSRVNT IHN0eWxlLA0KPiBzbyB0aGF0IE1JIG91dHB1dHMgb25lIHNpbmdsZSAiYWRk ciIgYXR0cmlidXRlLg0KPiANCj4gUGxlYXNlIHRyeSAiZ2RiIC1pPW1pIi4g IFlvdSBjYW4gc3RpbGwgdHlwZSBDTEkgY29tbWFuZHMsIHNvIGp1c3QgIihn ZGIpIHN0YXJ0Ig0KPiBhbmQgcnVubmluZyB0byBtYWluLCBzbyB0aGF0IEdE QiBwcmludHMgdGhlIGZyYW1lIGluIHRoZSAqc3RvcCBldmVudCBzaG91bGQN Cj4gYmUgc3VmZmljaWVudCB0byB0cmlnZ2VyIHRoaXMuDQoNCnN0b3AgZG9l c27igJl0IHRyaWdnZXIgYSBQQUMgYmVjYXVzZSBpdOKAmXMgb25seSBvbmNl IHdlIHJlZmVyZW5jZSBhIGZ1bmN0aW9uIHZpYSB0aGUNCmxpbmsgcmVnaXN0 ZXIgdGhhdCB0aGUgUEFDIHVubWFza2luZyBoYXBwZW5zLg0KDQpIb3dldmVy LCBzZWxlY3RpbmcgYSBwcmV2aW91cyBmcmFtZSBkb2VzLi4uLiBhbmQgdGhl IGlzc3VlcyBhcmUgb2J2aW91cyBub3c6DQoNCj10aHJlYWQtc2VsZWN0ZWQs aWQ9IjEiLGZyYW1lPXtsZXZlbD0iMSIsYWRkcj0iMHgwMDAwMDAwMDAwNDAw NWIwIixwYWM9IiBbUEFDXSIsZnVuYz0ibWFpbjMiLGFyZ3M9W10sZmlsZT0i Y2JyZWFrLTMuYyIsZnVsbG5hbWU9Ii9yb290L2NicmVhay0zLmMiLGxpbmU9 IjkiLGFyY2g9ImFhcmNoNjQifQ0KDQoNCj4gDQo+IEJUVywgdGhlcmUgYXJl IHR3byBvdGhlciBwbGFjZXMgd2hlcmUgd2Ugb3V0cHV0IHRoZSAiYWRkciIg ZmllbGQNCj4gaW4gdGhlIGZpbGUuICBEbyB5b3Ugd2FudCB0byBpbmNsdWRl ICJbUEFDXSIgaW4gdGhvc2U/ICBJZiBzbywNCj4gdGhlbiBmYWN0b3Jpbmcg b3V0IHRoZSAiYWRkciIgcHJpbnRpbmcgdG8gYSBzZXBhcmF0ZSBmdW5jdGlv bg0KPiB3b3VsZCBiZSBhcHByb3ByaWF0ZS4NCj4gDQoNCk9rLCBJIGNhbiBk byB0aGF0Lg0KDQoNCg0KDQo+IE9uIDggQXVnIDIwMTksIGF0IDE3OjU4LCBU b20gVHJvbWV5IDx0b21AdHJvbWV5LmNvbT4gd3JvdGU6DQo+IA0KPj4+Pj4+ ICJQZWRybyIgPT0gUGVkcm8gQWx2ZXMgPHBhbHZlc0ByZWRoYXQuY29tPiB3 cml0ZXM6DQo+IA0KPiBQZWRybz4gSG1tLCBJIGhhZCBzdWdnZXN0ZWQgY29u c2lkZXJpbmcgTUkgaW4gdGhlIHByZXZpb3VzIGl0ZXJhdGlvbiwgYnV0DQo+ IFBlZHJvPiBJIHdhcyBqdXN0IHRoaW5raW5nIG9mIGluY2x1ZGluZyB0aGUg IltQQUNdIiB0ZXh0IGluIHRoZQ0KPiBQZWRybz4gImFkZHIiIGZpZWxkLiAg SWYgd2UncmUgYWRkaW5nIGEgbmV3IGZpZWxkLCB0aGVuIGEgZmV3IGV4dHJh DQo+IFBlZHJvPiB0aGluZ3MgbmVlZCB0byBiZSBjb25zaWRlcmVkOg0KPiAN Cj4gUGVkcm8+ICAjMSAtIGRvY3VtZW50YXRpb24sIGJvdGggbWFudWFsIGFu ZCBORVdTIHNob3VsZCBtZW50aW9uIHRoaXMgbmV3IE1JIGZpZWxkLg0KPiAN Cj4gT29wcywgSSBmb3Jnb3QgYWJvdXQgdGhpcy4gIFNvcnJ5IGFib3V0IHRo YXQuDQoNCknigJlsbCBhZGQgc29tZXRoaW5nLg0KDQo+IA0KPiBJIGRvbid0 IHRoaW5rIHB1dHRpbmcgdGhpcyBpbmZvcm1hdGlvbiBpbnRvIHRoZSAiYWRk ciIgZmllbGQgaXMgYSBnb29kDQo+IGlkZWEuICBJdCdzIGJldHRlciwgSU1P LCB0byBsZXQgTUkgZmllbGQgbmFtZXMgcHJvdmlkZSB0aGUgc3RydWN0dXJl LA0KPiByYXRoZXIgdGhhbiByZXF1aXJpbmcgY2xpZW50cyB0byBhbHNvIHBh cnNlIHRoZSB2YWx1ZXMgb2YgZmllbGRzLg0KPiANCj4gSSByZWFsaXplIE1J IGlzbid0IDEwMCUgY2xlYW4gb24gdGhpcyB0b3BpYywgYnV0IHdlIGNhbiBz dGlsbCBub3QgbWFrZQ0KPiBpdCB3b3JzZS4NCj4gDQo+IFBlZHJvPiAgIzIg LSBjYWxsaW5nIHRoZSBhdHRyaWJ1dGUgInBhYyIgbWFrZXMgaXQgYXJjaGl0 ZWN0dXJlIHNwZWNpZmljLiANCj4gDQo+IEkgZG9uJ3QgdGhpbmsgdGhpcyBp cyBzdWNoIGEgYmlnIGRlYWwgYnV0IGF0IHRoZSBzYW1lIHRpbWUgYW55DQo+ IHJlYXNvbmFibGUgbmFtZSBpcyBmaW5lIGJ5IG1lLg0KPiANCj4gUGVkcm8+ ICAjMyAtIFRoZSBNSSBhdHRyaWJ1dGUgaXMgY2FsbGVkICJwYWMiLCBhbmQg aXRzIGNvbnRlbnQgaXMNCj4gUGVkcm8+ICAgICAgIGxpdGVyYWxseSAiIFtQ QUNdIi4gIEknZCBmaW5kIHRoYXQgb2RkIGlmIEkgd2VyZSBhIGZyb250ZW5k IGF1dGhvcjoNCj4gUGVkcm8+ICAgICAgIHRoZSBjb250ZW50IGlzIHJpZ2h0 IGFsaWduZWQgd2l0aCBhIHNwYWNlLCBtYWtpbmcgZG9pbmcgYW55dGhpbmcg d2l0aA0KPiBQZWRybz4gICAgICAgaXQgb3RoZXIgdGhhbiBhcHBlbmRpbmcg aXQgdG8gdGhlIGFkZHJlc3MgdGV4dCBwcm9iYWJseSBsb29rIG9kZCwNCj4g UGVkcm8+ICAgICAgIHVubGVzcyB5b3UgYmFrZSBpbiBhd2FyZW5lc3Mgb2Yg dGhlIGF0dHJpYnV0ZSdzIHRleHQuLi4gIElmIEkgc2F3DQo+IFBlZHJvPiAg ICAgICBhbiBhdHRyaWJ1dGUgbmFtZWQgInBhYyIsIEknZCBleHBlY3QgaXQg dG8gYmUgYSBib29sZWFuPyAgQXQgdGhlDQo+IFBlZHJvPiAgICAgICBsZWFz dCwgdGhlIGxlZnQgc3BhY2Ugc2hvdWxkIG5vdCBiZSBwYXJ0IG9mIHRoZSBm aWVsZCwgSSB0aGluaz8NCj4gDQo+IEkgdGhpbmsgcGFydCBvZiB0aGUgcGFp biBoZXJlIGlzIGFuIGludGVybmFsIGNvbnN0cmFpbnQsIG5hbWVseSB0aGF0 IHRoZQ0KPiBDTEkgdWktb3V0IHdvdWxkbid0IGtub3cgdG8gcmV3cml0ZSB0 aGUgYm9vbGVhbiB2YWx1ZSB0byBzb21ldGhpbmcgZWxzZQ0KPiBoZXJlLiAg QnV0IHBlcmhhcHMgdGhhdCdzIHNvbWV0aGluZyB0aGF0IGNvdWxkIGp1c3Qg YmUgYWRkcmVzc2VkDQo+IGRpcmVjdGx5Lg0KDQpJdCBsb29rcyBsaWtlIGZp eGluZyB0aGUgc3BhY2UganVzdCByZXF1aXJlcyBhbiBhZGRpdGlvbmFsIGNh bGwgdG8gdWlvdXQtPnRleHQgKCIg4oCcKS4NCg0KDQpIb3cgYWJvdXQgSSBj cmVhdGUgYSBuZXcgZmllbGQgYWRkcl9mbGFncz8gSXQgd291bGQgYmUgYSBn ZW5lcmljIGZpZWxkIGludG8gd2hpY2gNCnRhcmdldHMgY2FuIGFkZCB3aGlj aGV2ZXIgZmllbGRzIHRoZXkgd2FudCB0by4NCg0KSSB0aGVuIGNvdWxkIGFk ZCBhIGNhbGwgdG8gYSBuZXcgZnVuY3Rpb24gZ2RiYXJjaF9wcmludF9hZGRy X2ZsYWdzKCkgd2hpY2ggcHJpbnRzIHRoZQ0KUEFDIG9uIEFBcmNoNjQgYW5k IG5vdGhpbmcgb24gYWxsIG90aGVyIHRhcmdldHM/DQoNCg0KDQoNCkFsYW4u >From gdb-patches-return-158085-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Aug 09 13:57:50 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 13913 invoked by alias); 9 Aug 2019 13:57:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 13847 invoked by uid 89); 9 Aug 2019 13:57:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*M:b632 X-HELO: mail-wm1-f50.google.com Received: from mail-wm1-f50.google.com (HELO mail-wm1-f50.google.com) (209.85.128.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Aug 2019 13:57:48 +0000 Received: by mail-wm1-f50.google.com with SMTP id f72so5804662wmf.5 for ; Fri, 09 Aug 2019 06:57:48 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id x6sm105129693wrt.63.2019.08.09.06.57.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2019 06:57:46 -0700 (PDT) Subject: Re: [PATCH][gdb] Fix gdb.arch/amd64-tailcall-*.exp with -fPIE/-pie To: Tom de Vries , gdb-patches@sourceware.org References: <20190809104848.GA6563@delia> Cc: Jan Kratochvil From: Pedro Alves Message-ID: <57ada901-a8d8-b632-f7d8-e42283314b5a@redhat.com> Date: Fri, 09 Aug 2019 13:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190809104848.GA6563@delia> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00222.txt.bz2 Content-length: 1814 On 8/9/19 11:48 AM, Tom de Vries wrote: > @@ -240,14 +242,38 @@ pretend_pc (struct frame_info *this_frame, struct tailcall_cache *cache) > gdb_assert (next_levels >= 0); > > if (next_levels < chain->callees) > - return chain->call_site[chain->length - next_levels - 1]->pc; > + { > + struct call_site *call_site > + = chain->call_site[chain->length - next_levels - 1]; > + CORE_ADDR addr = call_site->pc; > + struct dwarf2_per_objfile *dwarf2_per_objfile > + = call_site->per_cu->dwarf2_per_objfile; > + struct objfile *objfile = dwarf2_per_objfile->objfile; > + CORE_ADDR baseaddr > + = ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile)); > + struct gdbarch *gdbarch = get_objfile_arch (objfile); > + addr = gdbarch_adjust_dwarf2_addr (gdbarch, addr + baseaddr); > + return addr; > + } > next_levels -= chain->callees; > > /* Otherwise CHAIN->CALLEES are already covered by CHAIN->CALLERS. */ > if (chain->callees != chain->length) > { > if (next_levels < chain->callers) > - return chain->call_site[chain->callers - next_levels - 1]->pc; > + { > + struct call_site *call_site > + = chain->call_site[chain->callers - next_levels - 1]; > + CORE_ADDR addr = call_site->pc; > + struct dwarf2_per_objfile *dwarf2_per_objfile > + = call_site->per_cu->dwarf2_per_objfile; > + struct objfile *objfile = dwarf2_per_objfile->objfile; > + CORE_ADDR baseaddr > + = ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile)); > + struct gdbarch *gdbarch = get_objfile_arch (objfile); > + addr = gdbarch_adjust_dwarf2_addr (gdbarch, addr + baseaddr); > + return addr; > + } It seems like there's a repeated pattern here. How about factoring out the common code to a function? Thanks, Pedro Alves