From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28505 invoked by alias); 5 Jun 2011 20:55:17 -0000 Received: (qmail 28496 invoked by uid 22791); 5 Jun 2011 20:55:16 -0000 X-SWARE-Spam-Status: No, hits=0.1 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mailrelay006.isp.belgacom.be (HELO mailrelay006.isp.belgacom.be) (195.238.6.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 05 Jun 2011 20:54:51 +0000 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EAOLq601tgKfh/2dsb2JhbABThEqFTpwdeIhqB64Gj1cOgR2DbIEKBKA1 Received: from 225.167-128-109.adsl-dyn.isp.belgacom.be (HELO soleil) ([109.128.167.225]) by relay.skynet.be with SMTP; 05 Jun 2011 22:54:49 +0200 Message-ID: From: "Philippe Waroquiers" To: "Pedro Alves" , Cc: "Yao Qi" , "Tom Tromey" References: <201105311830.59328.pedro@codesourcery.com> <1A6A06B5CD4346FEB0EAE0998527F07D@soleil> <201106011615.03444.pedro@codesourcery.com> Subject: Re: ping: Re: PATCH : allow to set length of hw watchpoints (e.g. for Valgrind gdbserver) Date: Sun, 05 Jun 2011 20:55:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8"; reply-type=original Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00081.txt.bz2 >> Note that one other thing that I find confusing in the current behaviour >> is that if you have a certain set of hw watchpoints that were accepted >> and you add a new one, you might obtain an error back referencing >> an "old" accepted watchpoint. >> >> I think it would be better if the watchpoints would always be re-inserted >> by gdb in the same order. > > I suppose that if we made insert_breakpoint_locations > walk breakpoints by increasing number instead of walking by > breakpoint locations, it'd be good enough. Yes, I think this is avoiding the strange behaviour of having an error on a previously accepted watchpoint. If breakpoint always-inserted is on, then I thinkl the error will appear immediately, which is also ok. Thanks for the patch to fix the 'busy' debug register on x86, I should be able to evaluate it end of this week. Philippe