From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65099 invoked by alias); 25 Jan 2018 16:13:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65069 invoked by uid 89); 25 Jan 2018 16:13:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0085.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jan 2018 16:13:20 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0184.eurprd08.prod.outlook.com (10.161.35.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 25 Jan 2018 16:13:16 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c95:81b8:c681:ae2]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c95:81b8:c681:ae2%17]) with mapi id 15.20.0444.015; Thu, 25 Jan 2018 16:13:16 +0000 From: Alan Hayward To: Yao Qi CC: Philipp Rudo , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 6/8] Create xml from target descriptions Date: Thu, 25 Jan 2018 16:13:00 -0000 Message-ID: References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> <20180125141423.1ff34025@ThinkPad> <86vafqc58o.fsf@gmail.com> In-Reply-To: <86vafqc58o.fsf@gmail.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0184;6:M/zEB7jIhkEn8cmw6AeH6s3wxpMDKFU93LUyOJ+JCV2Li5WN2ybXP6uGnozC1+sm6kcdLlkTpC9BCmWNnNxaMsL4n0GXMpWMJhjCMOIMjxx9zex4e43GVXrxUAZXNFBv7kh7/NfEf2aciezcoPO8jL67vo9rg7DEVprMhizhD2V8UhyRG9A4mtDYkr491szmBkVnliy5bgwMEoI9ltZDv786X6BHM/n1mI1tBVAABVJJkUdjaPn6PO7K9XE6ky74ICid+63fH9DGVwUN2VbFDWA5L+jba51YKVcdSBJm5Mh3v582LD8VFCokK8L+1P/wKxEH4jtIsWaIyrGJ8z3PuzlRO6+Q9zdfUxGgLJxxSlBSYC+NqStXeGO7WwwgLce3;5:yKm8smTyaaryzZ+8Wv1XEx8W8sibLyts4ZGK/eBHNGrKUohOIC06wSv8QssJu/mNNvs+GBdd9+2/ltPngr/n1ftEqPbrvTxzM6bWUnlgxyb6NSSfm5kDBlkYhz0ikh8i/ey7+ykEO9eUjFQ+HoxjBpZF481vNDz5YRIiTBp7v+g=;24:9lDzQZful1rqxKlBvv+r2aHCdW0Y7fs9jtJn/0UyFaRZJ5ra6xGZwlZobo+2RC+MqhG/tyzDwcZQESOmvIkO5PQCbNzG3E+Ht9Mthdaxt/4=;7:ZJs0Yajp4M307JSm10DlplJzNO9aSUFHGMlAlNn9bdPFORwAGSc4U0yL+48BUINWGPSRAJv9f2+VXTomubjkOGsw5oFUIR++VIPyjVnz2J48W8MWnq0HovSDdUbNyKI+dW7CqFBe0ArDVVh/Wrn4Pj/TFcXt7mAesn2ErrJFONgNFDAm6D1cEbc06P6XqxFGp2wbuvdPuj7PBOGxDsZmT8B8KVil33zaajVfEkzUlmdB6DhRAVqGKvwg+i7jx1j8 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8d1fa1de-d5d2-48f2-a83e-08d5640e8b01 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:AM3PR08MB0184; x-ms-traffictypediagnostic: AM3PR08MB0184: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(131327999870524)(85827821059158)(104084551191319); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041288)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(6072148)(201708071742011);SRVR:AM3PR08MB0184;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0184; x-forefront-prvs: 0563F2E8B7 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39380400002)(376002)(396003)(366004)(346002)(39860400002)(189003)(199004)(51914003)(81166006)(81156014)(6436002)(76176011)(25786009)(6246003)(5660300001)(105586002)(3660700001)(106356001)(305945005)(82746002)(72206003)(7736002)(14454004)(8936002)(2906002)(6506007)(53546011)(68736007)(26005)(8676002)(4743002)(83716003)(478600001)(2950100002)(102836004)(6916009)(6116002)(39060400002)(3846002)(2900100001)(316002)(97736004)(36756003)(86362001)(53936002)(54906003)(1411001)(66066001)(6486002)(93886005)(229853002)(186003)(4326008)(3280700002)(33656002)(5250100002)(99286004)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0184;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: PBBmoGxqrcGRlWXpTL8Dg/Wn8AQ75xzyYkb1HL+jdYT8UclT56QlfIpVvDbLxkT9aPWljCMHStdot21lFifYtg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <90BC5032BA35C649BEFA96D2BF6F274A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d1fa1de-d5d2-48f2-a83e-08d5640e8b01 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2018 16:13:16.6160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0184 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00533.txt.bz2 DQoNCg0KPiBPbiAyNSBKYW4gMjAxOCwgYXQgMTM6MTQsIFBoaWxpcHAgUnVk byA8cHJ1ZG9AbGludXgudm5ldC5pYm0uY29tPiB3cm90ZToNCj4gDQo+IA0K PiBpIGRvbid0IHJlYWxseSBsaWtlIHByaW50X3htbF9mZWF0dXJlOjp2aXNp dF9wcmUgYmVpbmcgZGVjbGFyZWQgaW4gYXJjaC90ZGVzYy5oDQo+IHdpdGgg ZGlmZmVyZW50IGltcGxlbWVudGF0aW9ucyBpbiB0YXJnZXQtZGVzY3JpcHRp b25zLmMgYW5kIGdkYnNlcnZlci90ZGVzYy5jDQo+IHdoaWxlIGFsbCBvdGhl ciB2aXNpdF8qIGltcGxlbWVudGF0aW9ucyBhcmUgaW4gYXJjaC90ZGVzYy5j LiAgSSB3b3VsZCBwcmVmZXJlDQo+IHZpc2l0X3ByZSBiZWluZyBpbXBsZW1l bnRlZCBpbiBhcmNoL3RkZXNjLmMsIHRvby4gIEV2ZW4gd2hlbiBpdCBtZWFu cyB0byBhZGQNCj4gc29tZSAjaWZkZWYgR0RCU0VSVkVSIC4uLiAjZWxzZSAu Li4gI2VuZGlmIGJsb2NrcyB1bnRpbCB0aGVyZSBpcyBhIGNvbW1vbiB0ZGVz Yy4NCg0KVGhhbmtzIGZvciB0aGUgcmV2aWV3IQ0KDQpBIGNvbW1vbiBwcmlu dF94bWxfZmVhdHVyZSB3b3VsZCByZXF1aXJlIDQgaWZkZWZzLCB3aGljaCB3 b3VsZCBiZSB0b28gbWVzc3kuDQpJ4oCZbGwgdGFrZSBhIGxvb2sgc2VlIGlm IEkgY2FuIGNvbW11bmlzZSB0aGUgdGRlc2NfYXJjaGl0ZWN0dXJlIGFuZCB0 ZGVzY19vc2FiaQ0KaW50ZXJmYWNlcyAtIGl0IHNob3VsZCBiZSBmYWlybHkg c2ltcGxlIHRvIGRvLg0KT25jZSBkb25lLCBJIHNob3VsZCBiZSBhYmxlIHRv IGFkZCBhIGNvbW1vbiBwcmludF94bWxfZmVhdHVyZSB3aXRob3V0IGFueQ0K aWZkZWZzLiBIb3BlZnVsbHkuDQoNCg0KPiBPbiAyNSBKYW4gMjAxOCwgYXQg MTU6NDQsIFlhbyBRaSA8cWl5YW9sdGNAZ21haWwuY29tPiB3cm90ZToNCj4g DQo+IFBoaWxpcHAgUnVkbyA8cHJ1ZG9AbGludXgudm5ldC5pYm0uY29tPiB3 cml0ZXM6DQo+IA0KPj4gU2FtZSBmb3IgdGRlc2NfdHlwZTo6bWFrZV9nZGJf dHlwZSAocGF0Y2ggIzUpLiAgQnV0IGhlcmUgaSB3b3VsZCBwcmVmZXIgdG8g bm90DQo+PiBldmVuIGRlY2xhcmUgdGhlIG1ldGhvZCBmb3IgR0RCc2VydmVy LCBpLmUuDQo+PiANCj4+IHN0cnVjdCB0ZGVzY190eXBlDQo+PiB7DQo+PiAN Cj4+ICBbLi4uXQ0KPj4gDQo+PiAjaWZuZGVmIEdEQlNFUlZFUg0KPj4gIHZp cnR1YWwgdHlwZSAqbWFrZV9nZGJfdHlwZSAoc3RydWN0IGdkYmFyY2ggKmdk YmFyY2gpIGNvbnN0ID0gMDsNCj4+ICNlbmRpZg0KPj4gfTsNCj4+IA0KPj4g VGhlIHByb2JsZW0gaSBzZWUgd2l0aCBpbXBsZW1lbnRpbmcgc3R1YnMgY2Fs bGluZyBlcnJvciBpcyB0aGF0IHlvdSBjYW5ub3QgZmluZA0KPj4gb3V0IHlv dSBtYWRlIGEgbWlzdGFrZSB1bnRpbCB5b3UgY2FsbCB0aGUgZnVuY3Rpb24g ZHVyaW5nIHJ1bi10aW1lLiAgVGhpcyBnaXZlcw0KPj4gcm9vbSB0byBuYXN0 eSBidWdzIHdoaWNoIGNvdWxkIGVhc2lseSBiZSBwcmV2ZW50ZWQgd2hlbiB0 aGVyZSBpcyBhIGNvbXBpbGUgYnVnLg0KPiANCj4gDQo+IG1ha2VfZ2RiX3R5 cGUgYW5kIGdkYmFyY2ggc2hvdWxkbid0IGJlIHB1dCBpbnRvIGFyY2gvdGRl c2MuaCBhdCBhbGwsIGlmDQo+IHBvc3NpYmxlLiAgWW91IGNhbiBjcmVhdGUg YW4gc3ViLWNsYXNzIG9mIHRkZXNjX2VsZW1lbnRfdmlzaXRvciBpbiBnZGIN Cj4gc2lkZSwgYW5kIGNyZWF0ZSB0aGUgZ2RiIHR5cGUgYnkgdmlzaXRpbmcg dGhlc2UgZWxlbWVudHMsIGxpa2UgdGhpcywNCj4gDQo+IGNsYXNzIGdkYl90 eXBlX2NyZWF0b3IgOiBwdWJsaWMgdGRlc2NfZWxlbWVudF92aXNpdG9yDQri gKYuDQoNCk5pY2UgaWRlYS4gSSBjYW4gYWRkIGFuIGV4dHJhIHBhdGNoIGlu dG8gdGhlIHNlcmllcyB0byBkbyB0aGlzLg0KDQoNCg0K >From gdb-patches-return-145060-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Jan 25 16:19:59 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 87874 invoked by alias); 25 Jan 2018 16:19:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 87864 invoked by uid 89); 25 Jan 2018 16:19:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jan 2018 16:19:56 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 0771311024C7 for ; Thu, 25 Jan 2018 10:19:55 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ekFmeUV2gcGlpekFneXzvW; Thu, 25 Jan 2018 10:19:55 -0600 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:44946 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eekFm-0027Vu-Pr; Thu, 25 Jan 2018 10:19:54 -0600 From: Tom Tromey To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/7] Class-fy partial_die_info References: <1516873114-7449-1-git-send-email-yao.qi@linaro.org> <1516873114-7449-5-git-send-email-yao.qi@linaro.org> Date: Thu, 25 Jan 2018 16:19:00 -0000 In-Reply-To: <1516873114-7449-5-git-send-email-yao.qi@linaro.org> (Yao Qi's message of "Thu, 25 Jan 2018 09:38:31 +0000") Message-ID: <87vafphpw6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eekFm-0027Vu-Pr X-Source-Sender: 71-218-90-63.hlrn.qwest.net (pokyo) [71.218.90.63]:44946 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-01/txt/msg00534.txt.bz2 Content-length: 796 >>>>> "Yao" == Yao Qi writes: Yao> @@ -18353,7 +18392,8 @@ load_partial_dies (const struct die_reader_specs *reader, Yao> struct partial_die_info *part_die Yao> = XOBNEW (&cu->comp_unit_obstack, struct partial_die_info); Yao> - memcpy (part_die, &pdi, sizeof (pdi)); Yao> + part_die = new (part_die) partial_die_info (pdi); Yao> + I wonder if it would make sense to have an "operator new" implementation that allocates directly on an obstack. It could use std::is_trivially_destructible to enforce the rule that objects on an obstack can't really be destroyed. This would eliminate the separate XOBNEW, which is maybe a potential source of errors; and would also make it harder to accidentally add a destructor to objects allocated this way. Tom