From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mFHxLtdNQGg0wAAAWB0awg (envelope-from ) for ; Wed, 04 Jun 2025 09:44:55 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=a4B0hYiE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BCA001E102; Wed, 4 Jun 2025 09:44:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5D6B91E0C2 for ; Wed, 4 Jun 2025 09:44:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EBEFC3858415 for ; Wed, 4 Jun 2025 13:44:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EBEFC3858415 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=a4B0hYiE Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by sourceware.org (Postfix) with ESMTPS id 3BB863858D32 for ; Wed, 4 Jun 2025 13:44:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BB863858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3BB863858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::641 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749044663; cv=none; b=a5RRLVZ4wdy5uCqwyh7Q1OTyIw2De5651Wj8/zw7jagqiwv07VAFXq8tkd/1ozRSDOmlsESOgL+3SUNaP1j/TJkTtj011vmP9mcWzx4qkZ+zl+aAgFYkTUMCgd9kL6kHMCfVIqNZ0o7kTmQbnTElOYYnhwRk45skO+myPTdKuvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749044663; c=relaxed/simple; bh=sdyKJBaWRx8H0XKNh5P1LAJIxjgZV5alCkVt1R5+wlY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=phh0I16jfKKmkRIg6HZ9xqoa8ZwXyqRo6aXzNnLfNCmRgnESKMXX7HsSMzSZQOqUONxdUPdS1ZWKafXAMFYukmTLmF7qpBB2CMhIZ/JY7gRm6F1+VWnYeA/B8yqAl/EhwusL3tGc3bLjcjSFOVCdm9vwe9SUUbyrHARmmzNozQA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3BB863858D32 Received: by mail-pl1-x641.google.com with SMTP id d9443c01a7336-2351227b098so47750425ad.2 for ; Wed, 04 Jun 2025 06:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749044662; x=1749649462; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=S0spqtuaJLnwBHEqhtKJ/AHB3t2vD2V6LmxA6tbSbBE=; b=a4B0hYiEo68/BFPgP7j5ggpMONQtFzXY0vhNgVyGKD2H6FGTuZLBwittAJlRsTKvfB 1nEH+OHCMxQecIIgubC50gLDXCJhqRPja8oHFSOERlOAHkdPdma6hBzihKFRYGHwfIKK Hiyc42nYnoVMsPsLdePXLlKsEVteCLwniWZR5U6A5PTgRNkuYJ690SXW/dOh9IMmz88d a9cIDXa7VNtEpDQj/3p4XJ8I4VNiyw+ZJLhy+5hCFhUg9EBk5wmLbZ60ADkw7D1IxyQX dCyrFVlOpc7fi28qSTR+C7En7W2SdYv+7yhuErQmFsLsxKXvn3OLwMw4n7SMpGdus6cR C7xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749044662; x=1749649462; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S0spqtuaJLnwBHEqhtKJ/AHB3t2vD2V6LmxA6tbSbBE=; b=jfWSz8cgvMlfghUR2NTpvyFISKHHMZNZAZ13PlQ5st26+AcKsT7Uk2O52/vx1tx2+G lPfhmvGfdsZgjyqEsQ0TQ+YeZhjXSi6q3M1pOU4sF/j614Gh2Ktb/WRGZs90u1Ub4e6y e3W0z0+d8M6g3C09IohmNKLVN8bi1STZicND6TzHi9SyyD8WY5K+t1npOYnZDXB8xSdT dahSXXhAckZYNf2ywnxOM5bIfotvdBPs412nIMZNWzgsYlLKkXE7xQU7NoMRGyAs7htB usW4FKuKTTdfM75xdSZfjPzPfq5Dr6/nB1k98cqe8e3mb9HIJDZjswD5DVMAJvemLgzv bHFg== X-Gm-Message-State: AOJu0YxOu37s5yDzLbqCQVDDqppNWDGn/UVPYBkjAVBGRSpxGmHkOJPs MlwSyDmhCy/C1/8Ru5YON/vzX1u7Uq/bgwwc49mwRFuRjxEJZlgmQXe7 X-Gm-Gg: ASbGncu34k3LCKQnFX86Vt+/3lRHQe8eVPJDchbCR0wMsU+QmqPONokkMR6W03xqzD5 Z82EA2vqJm8xgZC0JXKBkouTAkIw+YC2tKCP1o5IQG2B59LQpWNv51dK/WeOzWqIHSPLUhls0eM VHyQs7kM3ebFD5uGxp4VFcq2Z2eKdmJyqB2qYweSenVbeaXHsTuOUme7eMoLgUZlpa1SKdLk8gK ZwNf9+0n+ztpugBkpxqJkgMsraVULueuJSWvPJ6SdfI6h3wWggYWnSSOlum08QC1zLW0wO3mUK5 UVLtWghhCPx1+ARFNrXNLU7i+bbr7gIdsi7wMAOSPdv4Bp0obMaWAqROwIGCW0I= X-Google-Smtp-Source: AGHT+IG6GRRd6U17fMIMarN/lxnG58lZVS7SNxgMuMpesyoLERUpp7jPjGHiGXVE8CXVqlwa4DmMFg== X-Received: by 2002:a17:902:cf10:b0:231:c9bb:60fd with SMTP id d9443c01a7336-235e11c91c8mr40676155ad.33.1749044662024; Wed, 04 Jun 2025 06:44:22 -0700 (PDT) Received: from [10.2.0.2] ([89.187.185.165]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506bc8a40sm104514535ad.2.2025.06.04.06.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 06:44:21 -0700 (PDT) Message-ID: <9feb7348-1dde-40cc-b21d-97671b8b3e39@gmail.com> Date: Wed, 4 Jun 2025 08:44:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb/alpha: Add target description support To: Simon Marchi References: <20250526151219.399450-1-yodel.eldar@gmail.com> <20250526151219.399450-2-yodel.eldar@gmail.com> <55cdf445-fee8-4e70-99c0-6d42eb68cd7d@simark.ca> Content-Language: en-US Cc: gdb-patches@sourceware.org, Yodel Eldar From: Yodel Eldar Autocrypt: addr=yodel.eldar@gmail.com; keydata= xjMEZxqXdhYJKwYBBAHaRw8BAQdAkletQdG3CLyANZyuf2t7Z9PK4b6HiT+DdSPUB2mHzmPN N1lvZGVsIEVsZGFyIChZb2RlbCBPcGVuUEdQIGtleSkgPHlvZGVsLmVsZGFyQGdtYWlsLmNv bT7ClgQTFggAPgIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBNPNGM1AbbuKZqn435Xu T7c2ZU2sBQJnI9xJBQkB6nhTAAoJEJXuT7c2ZU2sSQABANuu74MJKexa8V8kVNLhw68loN4x 2ZbojcfUOWd8Pf5HAQDn1XxmQFPMIUYahlXMMrwRyQE1m6HjtrolOELICzwxDM44BGcal3YS CisGAQQBl1UBBQEBB0Ao8jLdb8MoWybV77fXOiqY5jSmrPy+MgzzjrAzqURjZAMBCAfCfgQY FggAJgIbDBYhBNPNGM1AbbuKZqn435XuT7c2ZU2sBQJnI9wMBQkB6ngWAAoJEJXuT7c2ZU2s BlUA/0ZfDDmzKdC1khPMaRIv/gWedFd5Z8jWqh0rswF2LyeNAQD6PjBgliBhL1xTto+juM1b jctqRusjtyMyzG8/ps2iDQ== In-Reply-To: <55cdf445-fee8-4e70-99c0-6d42eb68cd7d@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/3/25 1:49 PM, Simon Marchi wrote: > On 5/26/25 11:12 AM, Yodel Eldar wrote: >> @@ -1715,11 +1696,39 @@ alpha_software_single_step (struct regcache *regcache) >> static struct gdbarch * >> alpha_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) >> { >> + tdesc_arch_data_up tdesc_data; >> + const struct target_desc *tdesc = info.target_desc; >> + >> /* Find a candidate among extant architectures. */ >> arches = gdbarch_list_lookup_by_info (arches, &info); >> if (arches != NULL) >> return arches->gdbarch; >> >> + if (tdesc == nullptr) >> + tdesc = tdesc_alpha; >> + >> + /* Validate target description. */ >> + if (tdesc_has_registers (tdesc)) >> + { >> + const struct tdesc_feature *feature; >> + bool valid_p; >> + >> + feature = tdesc_find_feature (tdesc, "org.gnu.gdb.alpha.core"); >> + if (feature == nullptr) >> + return nullptr; >> + >> + tdesc_data = tdesc_data_alloc (); >> + valid_p = true; >> + for (int i = 0; i < ALPHA_NUM_REGS; ++i) >> + valid_p &= tdesc_numbered_register (feature, tdesc_data.get (), i, >> + alpha_register_names[i]); >> + >> + if (!valid_p) >> + return nullptr; > Do we need to call tdesc_numbered_register for the register whose name > is ""? I suppose that we do, for backwards compatibility, when > debugging against a remote target that doesn't send a target > description? > > Simon Hi Simon and thanks for your time and question! I think we do, because (IIUC) suppose an older remote target responds to, say, a 'p n' packet, but the anonymous register is unaccounted for by the client, wouldn't that break compatibility? Can't say for certain, so I defer to your and the community's wisdom and err on the side of caution as I investigate it. Yodel