From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /A0VFfVf62ngszgAWB0awg (envelope-from ) for ; Fri, 24 Apr 2026 08:20:05 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=blkM4c1/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=P58AVciJ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SB/9zLnK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2VnuNBI8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 474881E067; Fri, 24 Apr 2026 08:20:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D4DC01E067 for ; Fri, 24 Apr 2026 08:20:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3E5974BB58DD for ; Fri, 24 Apr 2026 12:19:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3E5974BB58DD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=blkM4c1/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=P58AVciJ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SB/9zLnK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2VnuNBI8 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id E32EA4BA902E for ; Fri, 24 Apr 2026 12:19:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E32EA4BA902E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E32EA4BA902E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777033172; cv=none; b=xed4M/yEH/eT6pYDBtGehxvpEmDdtjxAbhJmVkUwzDuLWpoEUcrSsZCxmjFsrbDXQgbvJU5T5+8BFb5pVB9EfRwx+OqAXqnflDEgyW29ytE6Ef7lvH35kJkI1ExhL9hnrQIMJUCrZeBaguZEbXxu8bgXVLCSMps9k/dR7ls7fq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777033172; c=relaxed/simple; bh=XWvOP8mzrlseK0E9pP/Mnwws2vXUy3Oiqg7A0WvaO6c=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=h0qtn5bLpK6EJFy9GG8h+S12073kx7/Cz14dojVxz21yaMBe9b2SVXHHUm00W7tHhBacy5WHkozo9hm7HfgYWF7QhvizLpUQEkgbjH/NTkkJyMoJo2y8GBnM1feTMhY5tGOrW4TgxzbJPwCYxFNlW4nS3HeCOYQLfwfYzyWoOE4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E32EA4BA902E Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DA2145BDB5; Fri, 24 Apr 2026 12:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777033171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1zqaw3WdQfLWPHGRGOlpe+fp8VXh3OgJhPUf9nslSXI=; b=blkM4c1/fxuWrsmXXatJZ9t0+OqZu4w42H6jADiWMXeRoF7H0L41rQ7ZUacgTPv4TT0FQk sfZCPA6SYoZeKk6tlEvqUy7yBjs9SnI5/+Z1YrMVc7PlM0VVoDIYKAitM3a01gjzuPcbEw IvLjLkFsyLLiL4apFtVTmk7uqfGH8GY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777033171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1zqaw3WdQfLWPHGRGOlpe+fp8VXh3OgJhPUf9nslSXI=; b=P58AVciJKJMUNiPN7f5X8t7zRzCB1gLYomtQbOvOimEeYuTo+99PTZyNe1IhERd6qU4112 KU/+jsJcEtVUy4AQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777033170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1zqaw3WdQfLWPHGRGOlpe+fp8VXh3OgJhPUf9nslSXI=; b=SB/9zLnKvZBhEbd78g2wMvW46Y+tqKe29vB4ZXWuISCbBs4XwYa3ABIb861cAFv5q7JLx2 x3EZME2rVY/5lARtfyOyR/knjhikD3FcEP8IRZfE/vOQ0qp3MHWzmz9YQ4MMKRrQgKSmte myUUnN0myNpZIl8+oFc86n6jptdVM8o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777033170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1zqaw3WdQfLWPHGRGOlpe+fp8VXh3OgJhPUf9nslSXI=; b=2VnuNBI8dbNgGGNht+VIb8RmsSoEupWhTN53FsvzhvcA+1AjzvVlW9NSGla2qnzfnYa5Jx EyqWdRyNkJeSpoCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C2DA0593A4; Fri, 24 Apr 2026 12:19:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gRMuLtJf62nBbQAAD6G6ig (envelope-from ); Fri, 24 Apr 2026 12:19:30 +0000 Message-ID: <9fae795b-1285-4e8f-9cf4-01e7bc7d21e9@suse.de> Date: Fri, 24 Apr 2026 14:19:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] [gdb] Use block::function_block To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260423063530.1074175-1-tdevries@suse.de> <20260423063530.1074175-2-tdevries@suse.de> <87wlxxpwz0.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87wlxxpwz0.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:email, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/23/26 4:33 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Use block::function_block to simplify get_frame_function. > > It would be even simpler to have it use block::containing_function, > which AFAICT is identical to the current code. > Hi, thanks for the review. I've: - update the patch to use block::containing_function, - updated $subject to "[gdb] Simplify get_frame_function", and - pushed. Thanks, - Tom > Tom