From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-135453-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13027 invoked by alias); 30 Nov 2016 15:36:51 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 13003 invoked by uid 89); 30 Nov 2016 15:36:50 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 15:36:49 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 5BFA5CA608;	Wed, 30 Nov 2016 15:36:48 +0000 (UTC)
Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUFakN1023833;	Wed, 30 Nov 2016 10:36:47 -0500
Subject: Re: [PATCH] Prevent turning record on while threads are running (PR 20869)
To: Luis Machado <lgustavo@codesourcery.com>,        Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
References: <20161129150758.29912-1-simon.marchi@ericsson.com> <fef2bdd4-d5c8-14a8-73ed-329b27961f1b@codesourcery.com> <8b198908-9a78-d2e8-1726-a471d3afb9b7@ericsson.com> <b9d5bbc8-3656-d680-e1ae-0e2e342e1437@codesourcery.com>
Cc: markus.t.metzger@intel.com
From: Pedro Alves <palves@redhat.com>
Message-ID: <9f8a9bbd-555a-bee8-52f8-46423702df95@redhat.com>
Date: Wed, 30 Nov 2016 15:36:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <b9d5bbc8-3656-d680-e1ae-0e2e342e1437@codesourcery.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-11/txt/msg00993.txt.bz2

On 11/29/2016 04:47 PM, Luis Machado wrote:
> On 11/29/2016 10:42 AM, Simon Marchi wrote:
>> On 16-11-29 10:58 AM, Luis Machado wrote:
>>>> +if ![supports_reverse] {
>>>
>>> Add an explicit untested call here?
>>
>> Right, adding:
>>
>> untested "reverse debugging not supported"

Shouldn't it be "unsupported" ?

> The above looks good to me.

Agreed.

Thanks,
Pedro Alves