From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SavGDqAqKWqgTz8AWB0awg (envelope-from ) for ; Wed, 10 Jun 2026 05:13:04 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qnI1Rknf; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=upDW4cwX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qnI1Rknf; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=upDW4cwX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 37A821E024; Wed, 10 Jun 2026 05:13:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 53D5E1E024 for ; Wed, 10 Jun 2026 05:13:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E2AB04BA2E29 for ; Wed, 10 Jun 2026 09:13:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E2AB04BA2E29 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qnI1Rknf; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=upDW4cwX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qnI1Rknf; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=upDW4cwX Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id EEF6B4BA2E09 for ; Wed, 10 Jun 2026 09:12:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EEF6B4BA2E09 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EEF6B4BA2E09 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781082756; cv=none; b=DnADd94ZMbq6QC7jyk4I7VCIF7TFhRyZtGBl3CVYiGF8mBETmeJOZs0hpj7oBe95g7lPvL8PMg7E9vqjYWb53Fn83ehXs61YBbqKF95lw1u9BtCdMmt7VOpl3WloRroDvYPp69ddrCUpCHb1uLosCSqqxjZxKSPrf7CDZAzqBOY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781082756; c=relaxed/simple; bh=ruRjJo1Vig7L2S7rpkW1s+Aq746opJuIqA11SNozjVI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=MUnimpAjVsNnuae/fUrb17rX6esnGJfoUSBFrD0Ph/3xKCl66V92qMYECcKFj11sjxrQinZhUEJmE1Si7gOkigctsTQgJFDFf/BcyMQ2QsNID/OIAkhqloiZnqq4Rlt21MSbUIGyE4bZOYUE68pvze7vhJyx3Q+3lU7xeJeIn8Y= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qnI1Rknf; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=upDW4cwX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qnI1Rknf; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=upDW4cwX DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EEF6B4BA2E09 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 069D7759E6; Wed, 10 Jun 2026 09:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781082755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oGOHFNHoaTMrL4nfPcNv0DpZ9R8QbWYfWO79UUDAyoE=; b=qnI1RknfrdMnt1PiGNg7DL5qGopPZs6l+bLqVZjWob37LvGMIGwM0EajXIDnpMHdAdZvk6 vETUMrLChETC7P9Uniq5q65GnJwxKip9EDmwqVteIRZMSwjOOKKhvhWRVBWkCJL5+mkJ4X MyxCm0kOdQ9/Marhiy1VdYKoLxxzlH8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781082755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oGOHFNHoaTMrL4nfPcNv0DpZ9R8QbWYfWO79UUDAyoE=; b=upDW4cwXhAx+xk/797FeInnIP7CZqI3HGi02r1wNZu0+0cTCZSgsHm0Ua5Vc9BFXaL+ln6 0nazXHyr735TKHDg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781082755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oGOHFNHoaTMrL4nfPcNv0DpZ9R8QbWYfWO79UUDAyoE=; b=qnI1RknfrdMnt1PiGNg7DL5qGopPZs6l+bLqVZjWob37LvGMIGwM0EajXIDnpMHdAdZvk6 vETUMrLChETC7P9Uniq5q65GnJwxKip9EDmwqVteIRZMSwjOOKKhvhWRVBWkCJL5+mkJ4X MyxCm0kOdQ9/Marhiy1VdYKoLxxzlH8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781082755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oGOHFNHoaTMrL4nfPcNv0DpZ9R8QbWYfWO79UUDAyoE=; b=upDW4cwXhAx+xk/797FeInnIP7CZqI3HGi02r1wNZu0+0cTCZSgsHm0Ua5Vc9BFXaL+ln6 0nazXHyr735TKHDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E4B7B779A7; Wed, 10 Jun 2026 09:12:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id PL57NoIqKWo9KgAAD6G6ig (envelope-from ); Wed, 10 Jun 2026 09:12:34 +0000 Message-ID: <9f5dcdf7-f51b-4a7a-8903-6fd072876fea@suse.de> Date: Wed, 10 Jun 2026 11:12:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] [gdb/contrib] Fix UnicodeDecodeError in dwarf-to-dwarf-assembler.py To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260608125420.2318026-1-tdevries@suse.de> <20260608125420.2318026-3-tdevries@suse.de> <87wlw7ej6u.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87wlw7ej6u.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:email, suse.de:mid, python.org:url] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/9/26 7:07 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> + return self._format_str(self.value.decode("ascii")) > > Probably we should decode using UTF-8 here, maybe with some fallback > setting, like errors='replace', see > > https://docs.python.org/3/library/stdtypes.html#bytes.decode > > The choice of encoding is a bit tricky since technically DWARF only uses > Unicode when some other flag is seen. However I think it's normally > fine and expected. > Thanks for the review. I've pushed this: ... - return self._format_str(self.value.decode("ascii")) + return self._format_str(self.value.decode("UTF-8", "backslashreplace")) ... Thanks, - Tom > Tom