Re: [PATCH v3] gdb/testsuite: add test for memory requirements of gcore

Tom Tromey
2025-03-04T18:19:48Z

>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:

Guinevere> The test runs twice, once with the inferior allocating 4Mb of memory,
Guinevere> and the other allocating 64Mb. My plan was to find the rate at which
Guinevere> things increase based on inferior size, and have that tested to ensure
Guinevere> we're not growing that requirement accidentally, but my testing
Guinevere> actually showed memory requirements going down as the inferior increases,
Guinevere> so instead I just hardcoded that we need less than 2Mb for the command,
Guinevere> and it can be tweaked later if necessary.

This seems fine to me. I didn't understand why it needed to attach, it
seems like just running it would be the same? But also it doesn't
really matter, considering you've done the work.

Approved-By: Tom Tromey <tom@tromey.com>

thanks,
Tom