From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70800 invoked by alias); 9 Aug 2017 15:42:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70787 invoked by uid 89); 9 Aug 2017 15:42:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_STOCKGEN,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Aug 2017 15:42:17 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 546AD11A88F for ; Wed, 9 Aug 2017 15:42:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 546AD11A88F Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths@redhat.com Received: from valrhona.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0205C6EE33; Wed, 9 Aug 2017 15:42:15 +0000 (UTC) Subject: Re: [PATCH 33/40] Make the linespec/location completer ignore data symbols To: Pedro Alves , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-34-git-send-email-palves@redhat.com> From: Keith Seitz Message-ID: <9f43d55f-44bc-f2c7-cbc9-a06d1666de5b@redhat.com> Date: Wed, 09 Aug 2017 15:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1496406158-12663-34-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00185.txt.bz2 On 06/02/2017 05:22 AM, Pedro Alves wrote: > > diff --git a/gdb/symtab.c b/gdb/symtab.c > index bbc317d..52cf70a 100644 > --- a/gdb/symtab.c > +++ b/gdb/symtab.c > @@ -5034,11 +5034,44 @@ completion_list_add_fields (completion_tracker &tracker, > } > } > > +/* See symtab.h. */ > + > +bool > +symbol_is_function_or_method (symbol *sym) > +{ > + switch (TYPE_CODE (SYMBOL_TYPE (sym))) > + { > + case TYPE_CODE_FUNC: > + case TYPE_CODE_METHOD: > + return true; > + default: > + return false; > + } > +} > + > +/* Return whether MSYMBOL is a function/method. */ > + I think "See symtab.h." is more customary here? > +bool > +symbol_is_function_or_method (minimal_symbol *msymbol) > +{ > + switch (MSYMBOL_TYPE (msymbol)) > + { > + case mst_text: > + case mst_text_gnu_ifunc: > + case mst_solib_trampoline: > + case mst_file_text: > + return true; > + default: > + return false; > + } > +} > + > /* Add matching symbols from SYMTAB to the current completion list. */ > > static void > add_symtab_completions (struct compunit_symtab *cust, > completion_tracker &tracker, > + complete_symbol_mode mode, > const lookup_name_info &lookup_name, > const char *text, const char *word, > enum type_code code) Otherwise, LGTM. Keith