From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20343 invoked by alias); 18 May 2018 18:50:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20326 invoked by uid 89); 18 May 2018 18:50:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 18:50:19 +0000 Received: by simark.ca (Postfix, from userid 112) id E32C51F21B; Fri, 18 May 2018 14:50:17 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 11E8A1F211; Fri, 18 May 2018 14:50:14 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 18 May 2018 19:00:00 -0000 From: Simon Marchi To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: New ARI warning Fri May 18 01:56:48 UTC 2018 In-Reply-To: <20180518182907.xhpjfk2jj2f3t65e@adacore.com> References: <20180518015648.GA106395@sourceware.org> <20180518182907.xhpjfk2jj2f3t65e@adacore.com> Message-ID: <9f29119c84b9d58b4499929bb752be78@simark.ca> X-Sender: simark@simark.ca User-Agent: Roundcube Webmail/1.3.6 X-SW-Source: 2018-05/txt/msg00408.txt.bz2 On 2018-05-18 14:29, Joel Brobecker wrote: > Hi Simon, > >> >> gdb/unittests/format_pieces-selftests.c:51: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value >> > gdb/unittests/format_pieces-selftests.c:51: check ("Hello %d%llx%%d", >> >> gdb/unittests/format_pieces-selftests.c:56: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value >> > gdb/unittests/format_pieces-selftests.c:56: format_piece ("%llx", long_long_arg), >> > >> >> These are false positives. > > You can tag them as OK with a /* ARI: ... */ comment. > > But I suspect we just want to exclude files in gdb/unittests instead? > Here is a patch that does that. Tested by checking the change in > output before and after: > > 1101,1120d1100 > < ./unittests/array-view-selftests.c > < ./unittests/common-utils-selftests.c > < ./unittests/environ-selftests.c > < ./unittests/function-view-selftests.c > < ./unittests/lookup_name_info-selftests.c > < ./unittests/memory-map-selftests.c > < ./unittests/memrange-selftests.c > < ./unittests/observable-selftests.c > < ./unittests/offset-type-selftests.c > < ./unittests/optional-selftests.c > < ./unittests/ptid-selftests.c > < ./unittests/rsp-low-selftests.c > < ./unittests/scoped_fd-selftests.c > < ./unittests/scoped_mmap-selftests.c > < ./unittests/scoped_restore-selftests.c > < ./unittests/string_view-selftests.c > < ./unittests/tracepoint-selftests.c > < ./unittests/unpack-selftests.c > < ./unittests/utils-selftests.c > < ./unittests/xml-utils-selftests.c > > gdb/ChangeLog: > > * contrib/ari/gdb_find.sh: Exclude the unittest directory. I don't really mind, maybe some rules related to formatting would still be appropriate for unittests/. Is is possible to exclude unittests/* instead of listing all the files? We'll surely add new files in there, and don't want to have to update that script every time. Simon