From: Simon Marchi <simon.marchi@efficios.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb/dwarf: fix failed assertion in dwarf2_find_containing_comp_unit selftest
Date: Thu, 27 Feb 2025 10:18:09 -0500 [thread overview]
Message-ID: <9ef97a4b-0151-4f24-ab40-868c2da9e9fc@efficios.com> (raw)
In-Reply-To: <44c1a9a8-fa96-43fb-bc8e-c3c67344f551@suse.de>
On 2/27/25 8:15 AM, Tom de Vries wrote:
> On 2/26/25 17:52, Simon Marchi wrote:
>> However, the dummy dwarf2_per_cu_data objects create the in
>> dwarf2_find_containing_comp_unit selftests are passed nullptr for those
>> parameters.
>
> Hi,
>
> I'm not sure I understand this sentence.
>
> create the in -> created in the ?
Oof, yes, thanks. I pushed the patches with that fixed.
Simon
next prev parent reply other threads:[~2025-02-27 15:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 16:52 [PATCH 1/2] gdb/dwarf: pass unit length to dwarf2_per_cu_data constructor Simon Marchi
2025-02-26 16:52 ` [PATCH 2/2] gdb/dwarf: fix failed assertion in dwarf2_find_containing_comp_unit selftest Simon Marchi
2025-02-27 13:12 ` Tom de Vries
2025-02-27 13:15 ` Tom de Vries
2025-02-27 15:18 ` Simon Marchi [this message]
2025-02-27 13:09 ` [PATCH 1/2] gdb/dwarf: pass unit length to dwarf2_per_cu_data constructor Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ef97a4b-0151-4f24-ab40-868c2da9e9fc@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox