From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0MVJNMt3PmMPeAYAWB0awg (envelope-from ) for ; Thu, 06 Oct 2022 02:38:03 -0400 Received: by simark.ca (Postfix, from userid 112) id D16611E112; Thu, 6 Oct 2022 02:38:03 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=LIk6FkYD; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 814C01E0CB for ; Thu, 6 Oct 2022 02:38:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 046E0384BC32 for ; Thu, 6 Oct 2022 06:38:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 046E0384BC32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665038283; bh=u37M3evY/mE+AuK8mqk4lVIpMhVeO//HtYXeKsz4tWk=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LIk6FkYDAmFeWi5wiVNFNYlIWLSuFqR0YeD+CagTcH3YdSaa1dQiD/yJ9J6UFUhiY I9IrzrmCRyZfKoqa98ltJnvPCwiuA76NGGqJmYTxUcQdTQu7QW1IhBLj2QfcsJ+baM 0GoPSgofDBIP3lLXi25GvV7huYkSJo3Cwyo61kdw= Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id E9331384BC3A for ; Thu, 6 Oct 2022 06:37:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E9331384BC3A Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 3D037300089; Thu, 6 Oct 2022 06:37:39 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Subject: [PATCH v2 6/7] sim/ppc: Add ATTRIBUTE_PRINTF Date: Thu, 6 Oct 2022 06:36:32 +0000 Message-Id: <9ee0350e33400397851bb55c129a675519e5f174.1665038133.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tsukasa OI via Gdb-patches Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to the printf-like functions. --- sim/ppc/main.c | 2 +- sim/ppc/misc.c | 4 ++-- sim/ppc/sim_calls.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sim/ppc/main.c b/sim/ppc/main.c index 83b629ec14a..04b2953762e 100644 --- a/sim/ppc/main.c +++ b/sim/ppc/main.c @@ -68,7 +68,7 @@ sim_io_printf_filtered(const char *msg, ...) va_end(ap); } -void +void ATTRIBUTE_PRINTF (1, 2) error (const char *msg, ...) { va_list ap; diff --git a/sim/ppc/misc.c b/sim/ppc/misc.c index 8f2581e3ef3..b8b11bcfe2f 100644 --- a/sim/ppc/misc.c +++ b/sim/ppc/misc.c @@ -28,7 +28,7 @@ #include #include -void +void ATTRIBUTE_PRINTF (1, 2) error (const char *msg, ...) { va_list ap; @@ -48,7 +48,7 @@ zalloc(long size) return memory; } -void +void ATTRIBUTE_PRINTF (2, 3) dumpf (int indent, const char *msg, ...) { va_list ap; diff --git a/sim/ppc/sim_calls.c b/sim/ppc/sim_calls.c index fbc327c94e0..24aeec3f298 100644 --- a/sim/ppc/sim_calls.c +++ b/sim/ppc/sim_calls.c @@ -388,7 +388,7 @@ sim_io_error (SIM_DESC sd, const char *fmt, ...) /****/ -void ATTRIBUTE_NORETURN +void ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2) error (const char *msg, ...) { va_list ap; -- 2.34.1