From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id D9EB738930EC for ; Mon, 22 Jun 2020 16:53:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D9EB738930EC Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-GEp8JY1QMSuNBHvoK0mSSA-1; Mon, 22 Jun 2020 12:53:55 -0400 X-MC-Unique: GEp8JY1QMSuNBHvoK0mSSA-1 Received: by mail-wr1-f72.google.com with SMTP id i12so2935319wrx.11 for ; Mon, 22 Jun 2020 09:53:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wDeB2c7r5CU4JxxWtbKYTFPbsFd9Yppow9wZqNP+Orw=; b=ga/El/Fu4etQ4UN9TcSD1PnMdqOKxkec3LflZ1QVeQ6XSkHftcvyRSaw4Lobj2eCp5 GMsGrNtoPE4C9/XW1ZzKyaVphekcJ4VqPoMmcPqKS2o7xdZ966q78+siP8J8qOYrJ/E4 s6F6n5WChZ9K1aufasfQuvYyiJI6fpWMxlwk1J7fHSobh2KWXllxpnMoHr+ibJ3Yaf7h eW2d0EZuqvIXD2a+YH2wWBXqgrMVjmFL6HqQmNIgNqNPKnSkIxvhnxwVFfefNsXg9XsN 6Cpwnp4K/klBhMFyx7xGiRwUrKHyQdggSZbHg2VGb+HyF/vyf+JBuJkJWxBj44Uo/B2i gPQQ== X-Gm-Message-State: AOAM531hzC87dhiBuLYjOVrJyjHVX8ovlM6+OybS+0LGGIOPUv9x2Agw CdiESuFKAqobnyLY1UeIQSrVg971iOd6LFbKBx3L2ygjNwKmTm+YvKTwin/lnmzRclFbPcj5wIB +90GEmRpuw7L/vW82poh6uQ== X-Received: by 2002:adf:f745:: with SMTP id z5mr20980384wrp.128.1592844833635; Mon, 22 Jun 2020 09:53:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDgjDb/l7vD2MReqkuxVOFy+T+IYV2QwqDvMHCfmBlcjfdgT3k/Qu132bXOx8FbbCF/zOwQQ== X-Received: by 2002:adf:f745:: with SMTP id z5mr20980378wrp.128.1592844833490; Mon, 22 Jun 2020 09:53:53 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id d13sm7616592wrq.89.2020.06.22.09.53.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2020 09:53:52 -0700 (PDT) Subject: Re: [PATCH v2 3/3] gdb/jit: enable tracking multiple jitter objfiles To: Simon Marchi , Tankut Baris Aktemur , gdb-patches@sourceware.org References: <4f7d8cfd9635484c5148e72f0941a0d9f369b7f3.1592299502.git.tankut.baris.aktemur@intel.com> <40e500a7-81ab-280a-1e40-d737d9aeb93f@simark.ca> <5ce80dbd-b9b1-f707-59e1-53a474037750@simark.ca> From: Pedro Alves Message-ID: <9ebadeca-4944-26e1-27bb-aa285d01447d@redhat.com> Date: Mon, 22 Jun 2020 17:53:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <5ce80dbd-b9b1-f707-59e1-53a474037750@simark.ca> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2020 16:53:57 -0000 On 6/22/20 5:39 PM, Simon Marchi wrote: > On 2020-06-22 12:28 p.m., Pedro Alves wrote: >> On 6/21/20 4:32 AM, Simon Marchi wrote: >>> >>> I would prefer #2, because using registries is kind of our standard way to keep >>> per-stuff data (where stuff is objfile, program_space, inferior, etc). >> >> I'd just like to point out that the main point of the registry mechanism >> is dynamic registration, which is useful when you have parts of the >> debugger that may or not be present in the final build. E.g., >> per-stuff data that is only used by some -tdep.c file. Otherwise, >> if we're talking about data used by some module that is _always_ >> included in the built, then IMO the registry stuff is an unnecessary >> abstraction. > > What would you use instead, an explicit field in the objfile structure? Yes. Thanks, Pedro Alves