From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1795 invoked by alias); 29 Nov 2016 21:14:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1466 invoked by uid 89); 29 Nov 2016 21:14:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*M:100c, spent, our, white X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Nov 2016 21:14:54 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cBpjo-0001eW-Rh from Luis_Gustavo@mentor.com ; Tue, 29 Nov 2016 13:14:52 -0800 Received: from [172.30.5.15] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 29 Nov 2016 13:14:50 -0800 Reply-To: Luis Machado Subject: Re: [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-5-git-send-email-lgustavo@codesourcery.com> <20161127170947.32vzeqciax5v275h@localhost> <20161129144851.GF22209@E107787-LIN> <20161129205524.xi3png66sw5quz5p@localhost> To: Yao Qi CC: From: Luis Machado Message-ID: <9eb49791-100c-148f-b641-b1ad234b029d@codesourcery.com> Date: Tue, 29 Nov 2016 21:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161129205524.xi3png66sw5quz5p@localhost> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00965.txt.bz2 On 11/29/2016 02:55 PM, Yao Qi wrote: > On Tue, Nov 29, 2016 at 09:06:54AM -0600, Luis Machado wrote: >> >> Why just that one? Shouldn't we attempt to enforce this for all the other >> proc's, so gdb_test, gdb_test_multiple, gdb_test_no_output and mi_gdb_test? >> > > because all of them except mi_gdb_test call gdb_test_multiple. > Ah, that makes sense. I thought i was missing something. >>>> >>>> It can be tricky, since one is still free to start the sentences >>>> with something like "ARM ..." or some other technology name. So >>>> unfortunately we can't be too strict. I wish we could. >>> >>> Do we have some many technology names? We have a white list of these >>> technology names which can be capitalized in test message. >>> >> >> It is certainly possible, but do we want to add one more layer of >> maintenance? We could enforce a rule from now on to require test names to >> always start with lowercase or to even be all lowercase. >> > > This is done by manual inspection in the patch review each time. The > automatic checking is much better than manual inspection. > Right. I agree that we don't want to have to keep inspecting things manually. So if we decide to go all lowercase even for technology, ISA or arch names, then i think we can enforce this better via the change to gdb_test_multiple (and mi_gdb_test). Then we don't have to maintain a whitelist at all. Does that sound reasonable? >> I don't think we're coherent with our use of lower/uppercase anyway. For >> example, GDBserver gets called gdbserver in gdbserver's own help text and >> the testsuite is (less so now with this series) a mixed bag. >> >> I'm open to ideas. > > We've spent some effort to convert GDB tests to comply to this rule, so > I am wondering if we can find some efficient way to enforce this rule, > otherwise, the violation to this rules may show up in the code some time > later. > I'd like that too.